You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2023/01/04 07:16:41 UTC

[GitHub] [dubbo] baerwang commented on a diff in pull request #11228: style:optimization-log4j

baerwang commented on code in PR #11228:
URL: https://github.com/apache/dubbo/pull/11228#discussion_r1061189827


##########
dubbo-common/src/main/java/org/apache/dubbo/common/logger/log4j/Log4jLoggerAdapter.java:
##########
@@ -26,11 +26,32 @@
 
 import java.io.File;
 import java.util.Enumeration;
+import java.util.HashMap;
+import java.util.Map;
 
 public class Log4jLoggerAdapter implements LoggerAdapter {
 
     private File file;
 
+    private static final Map<Level, org.apache.log4j.Level> toLevel = new HashMap<>();
+    private static final Map<org.apache.log4j.Level, Level> toApacheLevel = new HashMap<>();
+
+    static {
+        toLevel.put(Level.ALL, org.apache.log4j.Level.ALL);
+        toLevel.put(Level.TRACE, org.apache.log4j.Level.TRACE);
+        toLevel.put(Level.DEBUG, org.apache.log4j.Level.DEBUG);
+        toLevel.put(Level.INFO, org.apache.log4j.Level.INFO);
+        toLevel.put(Level.WARN, org.apache.log4j.Level.WARN);
+        toLevel.put(Level.ERROR, org.apache.log4j.Level.ERROR);
+
+        toApacheLevel.put(org.apache.log4j.Level.ALL, Level.ALL);
+        toApacheLevel.put(org.apache.log4j.Level.TRACE, Level.TRACE);
+        toApacheLevel.put(org.apache.log4j.Level.DEBUG, Level.DEBUG);
+        toApacheLevel.put(org.apache.log4j.Level.INFO, Level.INFO);
+        toApacheLevel.put(org.apache.log4j.Level.WARN, Level.WARN);
+        toApacheLevel.put(org.apache.log4j.Level.ERROR, Level.ERROR);

Review Comment:
   you re right



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org