You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "xujianhai666 (GitHub)" <gi...@apache.org> on 2020/03/21 02:31:20 UTC
[GitHub] [dubbo-go] xujianhai666 opened pull request #437: feat:
support json protocol with grpc
Closes #436
[ Full content available at: https://github.com/apache/dubbo-go/pull/437 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #437: feat:
support json protocol with grpc
Posted by "zouyx (GitHub)" <gi...@apache.org>.
add blank line
[ Full content available at: https://github.com/apache/dubbo-go/pull/437 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #437: feat:
support json protocol with grpc
Posted by "zouyx (GitHub)" <gi...@apache.org>.
add blank line
[ Full content available at: https://github.com/apache/dubbo-go/pull/437 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #437: feat: support
json protocol with grpc
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr&el=h1) Report
> Merging [#437](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/bde7db3b33067ee4115ea3f8666ec1169226a5de?src=pr&el=desc) will **decrease** coverage by `0.68%`.
> The diff coverage is `40.9%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #437 +/- ##
==========================================
- Coverage 67.41% 66.72% -0.69%
==========================================
Files 174 175 +1
Lines 9261 9283 +22
==========================================
- Hits 6243 6194 -49
- Misses 2416 2484 +68
- Partials 602 605 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/grpc/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9jb2RlYy5nbw==) | `40.9% <40.9%> (ø)` | |
| [filter/filter\_impl/metrics\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL21ldHJpY3NfZmlsdGVyLmdv) | `86.36% <0%> (-13.64%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0%> (-9.35%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `56.45% <0%> (-6.46%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `74.88% <0%> (-6.4%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `64.24% <0%> (-4.85%)` | :arrow_down: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <0%> (-3.39%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.3% <0%> (-2.84%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.36% <0%> (-0.66%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr&el=footer). Last update [bde7db3...f45f679](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/437 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #437: feat: support
json protocol with grpc
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr&el=h1) Report
> Merging [#437](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/bde7db3b33067ee4115ea3f8666ec1169226a5de?src=pr&el=desc) will **decrease** coverage by `0.68%`.
> The diff coverage is `40.9%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #437 +/- ##
==========================================
- Coverage 67.41% 66.72% -0.69%
==========================================
Files 174 175 +1
Lines 9261 9283 +22
==========================================
- Hits 6243 6194 -49
- Misses 2416 2484 +68
- Partials 602 605 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/grpc/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9jb2RlYy5nbw==) | `40.9% <40.9%> (ø)` | |
| [filter/filter\_impl/metrics\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL21ldHJpY3NfZmlsdGVyLmdv) | `86.36% <0%> (-13.64%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0%> (-9.35%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `56.45% <0%> (-6.46%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `74.88% <0%> (-6.4%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `64.24% <0%> (-4.85%)` | :arrow_down: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <0%> (-3.39%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.3% <0%> (-2.84%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.36% <0%> (-0.66%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/437/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr&el=footer). Last update [bde7db3...cb259e9](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/437 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org