You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/23 13:02:31 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #8280:
[superset] Slight performance improvement, remove SQLA first
codecov-io commented on issue #8280: [superset] Slight performance improvement, remove SQLA first
URL: https://github.com/apache/incubator-superset/pull/8280#issuecomment-534088744
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8280?src=pr&el=h1) Report
> Merging [#8280](https://codecov.io/gh/apache/incubator-superset/pull/8280?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6a08f25b151913b57032b7f4f30a766fedc338e2?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `54.54%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8280?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8280 +/- ##
==========================================
- Coverage 67.73% 67.72% -0.01%
==========================================
Files 451 451
Lines 22678 22679 +1
Branches 2370 2370
==========================================
- Hits 15360 15359 -1
- Misses 7181 7183 +2
Partials 137 137
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8280?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8280/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `69.94% <54.54%> (-0.12%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8280?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8280?src=pr&el=footer). Last update [6a08f25...ec175da](https://codecov.io/gh/apache/incubator-superset/pull/8280?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org