You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/02 19:07:27 UTC
[GitHub] [airflow] o-nikolas opened a new pull request, #24122: Breeze must create `hooks\` and `dags\` directories for bind mounts
o-nikolas opened a new pull request, #24122:
URL: https://github.com/apache/airflow/pull/24122
As of #23985 and #24026 Breeze now uses `--mount` instead of `--volume` (the former of which does not create missing mount dirs like the latter does, see explanation in the Docker docs [here](https://docs.docker.com/storage/bind-mounts/#differences-between--v-and---mount-behavior)) we need to create these directories explicitly. If not, a fresh clone of Airflow (which you need to notice this issue because if you've run an older version of Breeze the `hooks` and `dags` folders were created for you before the switch to `--mount`) will show you this error when running breeze:
```
$ breeze
Good version of Docker: 20.10.16.
Good version of docker-compose: 1.29.1
.
.
.
Docker image build is not needed for CI build as no important files are changed! You can add --force-build to force it
WARNING: The AIRFLOW_CONSTRAINTS_REFERENCE variable is not set. Defaulting to a blank string.
WARNING: The DEFAULT_CONSTRAINTS_BRANCH variable is not set. Defaulting to a blank string.
Creating docker-compose_airflow_run ... error
ERROR: for docker-compose_airflow_run Cannot create container for service airflow: invalid mount config for type "bind": bind source path does not exist: /home/onikolas/code/airflow/hooks
```
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24122: Breeze must create `hooks\` and `dags\` directories for bind mounts
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24122:
URL: https://github.com/apache/airflow/pull/24122#issuecomment-1145218331
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24122: Breeze must create `hooks\` and `dags\` directories for bind mounts
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24122:
URL: https://github.com/apache/airflow/pull/24122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org