[jspwiki] 03/06: fix issues raised by SonarQube

[ju...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

juanpablo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jspwiki.git

commit b05581533bd2dcb39f776ab8de78e60a33fbc673
Author: Juan Pablo Santos Rodríguez <ju...@gmail.com>
AuthorDate: Thu Oct 28 11:33:13 2021 +0200

    fix issues raised by SonarQube
---
 .../org/apache/wiki/htmltowiki/XHtmlElementToWikiTranslator.java  | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/jspwiki-main/src/main/java/org/apache/wiki/htmltowiki/XHtmlElementToWikiTranslator.java b/jspwiki-main/src/main/java/org/apache/wiki/htmltowiki/XHtmlElementToWikiTranslator.java
index 78ffbf7..cee0013 100644
--- a/jspwiki-main/src/main/java/org/apache/wiki/htmltowiki/XHtmlElementToWikiTranslator.java
+++ b/jspwiki-main/src/main/java/org/apache/wiki/htmltowiki/XHtmlElementToWikiTranslator.java
@@ -510,7 +510,7 @@ public class XHtmlElementToWikiTranslator {
         final String cssClass = a.getAttributeValue( "class" );
         if( StringUtils.isNotEmpty( cssClass )
                 && !cssClass.matches( "wikipage|createpage|external|interwiki|attachment" ) ) {
-            attributesMap.put( "class", cssClass.replaceAll( "'", "\"" ) );
+            attributesMap.put( "class", cssClass.replace( "'", "\"" ) );
         }
         addAttributeIfPresent( a, attributesMap, "accesskey" );
         addAttributeIfPresent( a, attributesMap, "charset" );
@@ -531,7 +531,7 @@ public class XHtmlElementToWikiTranslator {
     private void addAttributeIfPresent( final Element a, final Map< String, String > attributesMap, final String attribute ) {
         final String attr = a.getAttributeValue( attribute );
         if( StringUtils.isNotEmpty( attr ) ) {
-            attributesMap.put( attribute, attr.replaceAll( "'", "\"" ) );
+            attributesMap.put( attribute, attr.replace( "'", "\"" ) );
         }
     }
 
@@ -881,13 +881,15 @@ public class XHtmlElementToWikiTranslator {
 
     private class PreStack extends Stack< String > {
 
+        @Override
         public String push( final String item ) {
             final String push = super.push( item );
             outTrimmer.setWhitespaceTrimMode( isEmpty() );
             return push;
         }
 
-        public String pop() {
+        @Override
+        public synchronized String pop() {
             final String pop = super.pop();
             outTrimmer.setWhitespaceTrimMode( isEmpty() );
             return pop;