You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/14 04:25:18 UTC
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5133: ui: refactor labels with tooltip in forms
Pearl1594 commented on a change in pull request #5133:
URL: https://github.com/apache/cloudstack/pull/5133#discussion_r669269682
##########
File path: ui/src/views/storage/UploadLocalVolume.vue
##########
@@ -103,12 +88,7 @@
</a-select>
</a-form-item>
<a-form-item>
- <span slot="label">
- {{ $t('label.volumechecksum') }}
- <a-tooltip :title="apiParams.checksum.description">
- <a-icon type="info-circle" style="color: rgba(0,0,0,.45)" />
- </a-tooltip>
- </span>
+ <tooltip-label slot="label" :title="$t('label.volumechecksum')" :tooltip="apiParams.volumechecksum.description"/>
Review comment:
```suggestion
<tooltip-label slot="label" :title="$t('label.volumechecksum')" :tooltip="apiParams.checksum.description"/>
```
As the form fails to load with the following error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org