You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by samar kumar <sa...@gmail.com> on 2014/12/04 13:19:26 UTC
Re: Review Request 28508: Falcon client methods should return objects
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/
-----------------------------------------------------------
(Updated Dec. 4, 2014, 12:19 p.m.)
Review request for Falcon.
Changes
-------
changes after review comments
Bugs: FALCON-329
https://issues.apache.org/jira/browse/FALCON-329
Repository: falcon-git
Description
-------
Falcon client methods should return objects
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/ResponseParserHelper.java e69de29
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f
client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed
Diff: https://reviews.apache.org/r/28508/diff/
Testing
-------
Thanks,
samar kumar
Re: Review Request 28508: Falcon client methods should return objects
Posted by samar kumar <sa...@gmail.com>.
> On Dec. 12, 2014, 5:46 a.m., shwethags wrote:
> > Minor comment, will fix it and commit
Thanks!!
- samar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/#review64869
-----------------------------------------------------------
On Dec. 11, 2014, 12:48 p.m., samar kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28508/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 12:48 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-329
> https://issues.apache.org/jira/browse/FALCON-329
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon client methods should return objects
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/ResponseParserHelper.java e69de29
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f
> client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed
> webapp/src/main/java/org/apache/falcon/Debug.java a650215
>
> Diff: https://reviews.apache.org/r/28508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> samar kumar
>
>
Re: Review Request 28508: Falcon client methods should return objects
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/#review64869
-----------------------------------------------------------
Ship it!
Minor comment, will fix it and commit
client/src/main/java/org/apache/falcon/ResponseParserHelper.java
<https://reviews.apache.org/r/28508/#comment107663>
prefix method name with parse
- shwethags
On Dec. 11, 2014, 12:48 p.m., samar kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28508/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 12:48 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-329
> https://issues.apache.org/jira/browse/FALCON-329
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon client methods should return objects
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/ResponseParserHelper.java e69de29
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f
> client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed
> webapp/src/main/java/org/apache/falcon/Debug.java a650215
>
> Diff: https://reviews.apache.org/r/28508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> samar kumar
>
>
Re: Review Request 28508: Falcon client methods should return objects
Posted by samar kumar <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/
-----------------------------------------------------------
(Updated Dec. 11, 2014, 12:48 p.m.)
Review request for Falcon.
Changes
-------
Changed to Entity from String
Bugs: FALCON-329
https://issues.apache.org/jira/browse/FALCON-329
Repository: falcon-git
Description
-------
Falcon client methods should return objects
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/ResponseParserHelper.java e69de29
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f
client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed
webapp/src/main/java/org/apache/falcon/Debug.java a650215
Diff: https://reviews.apache.org/r/28508/diff/
Testing
-------
Thanks,
samar kumar