You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Pranay Pandey (JIRA)" <ji...@apache.org> on 2009/03/02 09:58:12 UTC

[jira] Created: (OFBIZ-2221) Functionality to add more then one product at a time to purchase order in order detail page

Functionality to add more then one product at a time to purchase order in order detail page
-------------------------------------------------------------------------------------------

                 Key: OFBIZ-2221
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2221
             Project: OFBiz
          Issue Type: Sub-task
          Components: order
    Affects Versions: SVN trunk
            Reporter: Pranay Pandey
            Priority: Minor
             Fix For: SVN trunk


Provide functionality to add more then one product at a time to purchase order in order detail page.

*Implementation Notes:*
Add multi-add form to Order Manager order detail page, at bottom with single add item form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2221) Functionality to add more then one product at a time to purchase order in order detail page

Posted by "Akash Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Akash Jain updated OFBIZ-2221:
------------------------------

    Attachment: OFBIZ-2221.patch

Minor change in the condition in OrderEntryCalalogTabBar.ftl file.

> Functionality to add more then one product at a time to purchase order in order detail page
> -------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2221
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2221
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2221.patch, OFBIZ-2221.patch
>
>
> Provide functionality to add more then one product at a time to purchase order in order detail page.
> *Implementation Notes:*
> Add multi-add form to Order Manager order detail page, at bottom with single add item form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2221) Functionality to add more then one product at a time to purchase order in order detail page

Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey updated OFBIZ-2221:
---------------------------------

    Attachment: OFBIZ-2221.patch

Thanks Akash for the updated patch.

Here I am uploading your patch again after small changes.
Also there were conflicts in this patch due to recent commits, I have resolved them as well.

In future please take an update before creating a patch.

> Functionality to add more then one product at a time to purchase order in order detail page
> -------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2221
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2221
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2221.patch, OFBIZ-2221.patch, OFBIZ-2221.patch, OFBIZ-2221.patch
>
>
> Provide functionality to add more then one product at a time to purchase order in order detail page.
> *Implementation Notes:*
> Add multi-add form to Order Manager order detail page, at bottom with single add item form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2221) Functionality to add more then one product at a time to purchase order in order detail page

Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683001#action_12683001 ] 

Pranay Pandey commented on OFBIZ-2221:
--------------------------------------

Thanks Akash for providing patch for this issue.

I reviewed and tested your patch there are few places that needs improvement:

#  After adding items to PO leaves a cart in place that causes problem when we go back to order entry screen.
    You can handle this in your event.

#  No need to create shopping cart object in your event as its not being used anywhere and the called service is handling it.

#  There are few more objects which are created but not being used, remove unused code.

#  Also the functionality to add a single product to the order is not working after applying the patch as orderId is not found in OrderView.groovy, correct this as well.

> Functionality to add more then one product at a time to purchase order in order detail page
> -------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2221
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2221
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2221.patch, OFBIZ-2221.patch
>
>
> Provide functionality to add more then one product at a time to purchase order in order detail page.
> *Implementation Notes:*
> Add multi-add form to Order Manager order detail page, at bottom with single add item form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (OFBIZ-2221) Functionality to add more then one product at a time to purchase order in order detail page

Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683001#action_12683001 ] 

Pranay Pandey edited comment on OFBIZ-2221 at 3/18/09 5:14 AM:
---------------------------------------------------------------

Thanks Akash for providing patch for this issue.

I reviewed and tested your patch there are few places that needs improvement:

#  After adding items to PO leaves a cart in place that causes problem when we go back to order entry screen. You can handle this in your event.
#  No need to create shopping cart object in your event as its not being used anywhere and the called service is handling it.
#  There are few more objects which are created but not being used, remove unused code.
#  Also the functionality to add a single product to the order is not working after applying the patch as orderId is not found in OrderView.groovy, correct this as well.

      was (Author: pandeypranay):
    Thanks Akash for providing patch for this issue.

I reviewed and tested your patch there are few places that needs improvement:

#  After adding items to PO leaves a cart in place that causes problem when we go back to order entry screen.
    You can handle this in your event.

#  No need to create shopping cart object in your event as its not being used anywhere and the called service is handling it.

#  There are few more objects which are created but not being used, remove unused code.

#  Also the functionality to add a single product to the order is not working after applying the patch as orderId is not found in OrderView.groovy, correct this as well.
  
> Functionality to add more then one product at a time to purchase order in order detail page
> -------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2221
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2221
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2221.patch, OFBIZ-2221.patch
>
>
> Provide functionality to add more then one product at a time to purchase order in order detail page.
> *Implementation Notes:*
> Add multi-add form to Order Manager order detail page, at bottom with single add item form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OFBIZ-2221) Functionality to add more then one product at a time to purchase order in order detail page

Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reassigned OFBIZ-2221:
----------------------------------

    Assignee: Vikas Mayur

> Functionality to add more then one product at a time to purchase order in order detail page
> -------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2221
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2221
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2221.patch, OFBIZ-2221.patch, OFBIZ-2221.patch
>
>
> Provide functionality to add more then one product at a time to purchase order in order detail page.
> *Implementation Notes:*
> Add multi-add form to Order Manager order detail page, at bottom with single add item form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-2221) Functionality to add more then one product at a time to purchase order in order detail page

Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur closed OFBIZ-2221.
------------------------------

    Resolution: Fixed

Thanks Akash and Pranay!

Patch is in trunk rev. 755627



> Functionality to add more then one product at a time to purchase order in order detail page
> -------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2221
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2221
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2221.patch, OFBIZ-2221.patch, OFBIZ-2221.patch, OFBIZ-2221.patch
>
>
> Provide functionality to add more then one product at a time to purchase order in order detail page.
> *Implementation Notes:*
> Add multi-add form to Order Manager order detail page, at bottom with single add item form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2221) Functionality to add more then one product at a time to purchase order in order detail page

Posted by "Akash Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Akash Jain updated OFBIZ-2221:
------------------------------

    Attachment: OFBIZ-2221.patch

Thanks Pranay for reviewing patch and giving comments for improvement. I done the needful changes.   

> Functionality to add more then one product at a time to purchase order in order detail page
> -------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2221
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2221
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2221.patch, OFBIZ-2221.patch, OFBIZ-2221.patch
>
>
> Provide functionality to add more then one product at a time to purchase order in order detail page.
> *Implementation Notes:*
> Add multi-add form to Order Manager order detail page, at bottom with single add item form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2221) Functionality to add more then one product at a time to purchase order in order detail page

Posted by "Akash Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Akash Jain updated OFBIZ-2221:
------------------------------

    Attachment: OFBIZ-2221.patch

This patch have the functionality in which user can add bulk products from order detail page, after the order is created. (In case of purchase order)

Steps for testing :
1) Create a purchase order
2) Then edit this particular order
3) Depress on Quick lookup link for adding bulk products in this order
4) Fill up the quantity for more than one products
5) Depress on Add to Order button
6) Selected products should be appended in this order and total price should also change accordingly.

> Functionality to add more then one product at a time to purchase order in order detail page
> -------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2221
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2221
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2221.patch
>
>
> Provide functionality to add more then one product at a time to purchase order in order detail page.
> *Implementation Notes:*
> Add multi-add form to Order Manager order detail page, at bottom with single add item form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.