You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "mcdull-zhang (via GitHub)" <gi...@apache.org> on 2024/03/29 12:48:01 UTC
[PR] [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy [celeborn]
mcdull-zhang opened a new pull request, #2432:
URL: https://github.com/apache/celeborn/pull/2432
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
The data push thread should first send requests to workers that are not under pressure.
Use PushStrategy's `currentMaxReqsInFlight` to better filter requests.
### Why are the changes needed?
Prevent blocking other requests
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2432:
URL: https://github.com/apache/celeborn/pull/2432#discussion_r1546249832
##########
client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java:
##########
@@ -106,7 +104,7 @@ public ArrayList<PushTask> takePushTasks() throws IOException, InterruptedExcept
if (loc != null) {
Integer oldCapacity = workerCapacity.get(loc.hostAndPushPort());
if (oldCapacity == null) {
- oldCapacity = maxInFlightPerWorker - pushState.inflightPushes(loc.hostAndPushPort());
+ oldCapacity = pushState.remainingAllowPushes(loc.hostAndPushPort());
Review Comment:
@mcdull-zhang, this changes means that the amount of netty in-flight requests per worker could not be configured, which cause that the user could not control the amount.
##########
client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java:
##########
@@ -106,7 +104,7 @@ public ArrayList<PushTask> takePushTasks() throws IOException, InterruptedExcept
if (loc != null) {
Integer oldCapacity = workerCapacity.get(loc.hostAndPushPort());
if (oldCapacity == null) {
- oldCapacity = maxInFlightPerWorker - pushState.inflightPushes(loc.hostAndPushPort());
+ oldCapacity = pushState.remainingAllowPushes(loc.hostAndPushPort());
Review Comment:
@mcdull-zhang, this changes means that the amount of netty in-flight requests per worker could not be configured, which cause that the user could not control the amount. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy [celeborn]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2432:
URL: https://github.com/apache/celeborn/pull/2432#issuecomment-2111895124
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2432:
URL: https://github.com/apache/celeborn/pull/2432#discussion_r1574369655
##########
client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java:
##########
@@ -106,7 +104,7 @@ public ArrayList<PushTask> takePushTasks() throws IOException, InterruptedExcept
if (loc != null) {
Integer oldCapacity = workerCapacity.get(loc.hostAndPushPort());
if (oldCapacity == null) {
- oldCapacity = maxInFlightPerWorker - pushState.inflightPushes(loc.hostAndPushPort());
+ oldCapacity = pushState.remainingAllowPushes(loc.hostAndPushPort());
Review Comment:
cc @RexXiong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy [celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #2432: [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy
URL: https://github.com/apache/celeborn/pull/2432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy [celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #2432:
URL: https://github.com/apache/celeborn/pull/2432#discussion_r1602463561
##########
client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java:
##########
@@ -106,7 +104,7 @@ public ArrayList<PushTask> takePushTasks() throws IOException, InterruptedExcept
if (loc != null) {
Integer oldCapacity = workerCapacity.get(loc.hostAndPushPort());
if (oldCapacity == null) {
- oldCapacity = maxInFlightPerWorker - pushState.inflightPushes(loc.hostAndPushPort());
+ oldCapacity = pushState.remainingAllowPushes(loc.hostAndPushPort());
Review Comment:
Hi @mcdull-zhang , I think you are right, `currentMaxReqsInFlight` differs between `SIMPLE` and `SLOWSTART`, and for the latter the `currentMaxReqsInFlight` can change.
This PR looks good to me. cc @AngersZhuuuu could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy [celeborn]
Posted by "mcdull-zhang (via GitHub)" <gi...@apache.org>.
mcdull-zhang commented on code in PR #2432:
URL: https://github.com/apache/celeborn/pull/2432#discussion_r1546275421
##########
client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java:
##########
@@ -106,7 +104,7 @@ public ArrayList<PushTask> takePushTasks() throws IOException, InterruptedExcept
if (loc != null) {
Integer oldCapacity = workerCapacity.get(loc.hostAndPushPort());
if (oldCapacity == null) {
- oldCapacity = maxInFlightPerWorker - pushState.inflightPushes(loc.hostAndPushPort());
+ oldCapacity = pushState.remainingAllowPushes(loc.hostAndPushPort());
Review Comment:
After this change,
If `PushStrategy`=`SIMPLE`, the logic is still the same as before this pr;
If `PushStrategy`=`SLOWSTART`, then `capacity=currentMaxReqsInFlight-Inflight`;
So it feels like the configuration is still valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2432:
URL: https://github.com/apache/celeborn/pull/2432#discussion_r1560966530
##########
client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java:
##########
@@ -106,7 +104,7 @@ public ArrayList<PushTask> takePushTasks() throws IOException, InterruptedExcept
if (loc != null) {
Integer oldCapacity = workerCapacity.get(loc.hostAndPushPort());
if (oldCapacity == null) {
- oldCapacity = maxInFlightPerWorker - pushState.inflightPushes(loc.hostAndPushPort());
+ oldCapacity = pushState.remainingAllowPushes(loc.hostAndPushPort());
Review Comment:
@mcdull-zhang, why not use `CongestControlContext#reqsInFlightBlockThreshold`? `reqsInFlightBlockThreshold` is different from `currentMaxReqsInFlight` in some cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2432:
URL: https://github.com/apache/celeborn/pull/2432#discussion_r1568717374
##########
client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java:
##########
@@ -106,7 +104,7 @@ public ArrayList<PushTask> takePushTasks() throws IOException, InterruptedExcept
if (loc != null) {
Integer oldCapacity = workerCapacity.get(loc.hostAndPushPort());
if (oldCapacity == null) {
- oldCapacity = maxInFlightPerWorker - pushState.inflightPushes(loc.hostAndPushPort());
+ oldCapacity = pushState.remainingAllowPushes(loc.hostAndPushPort());
Review Comment:
@mcdull-zhang, any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy [celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #2432:
URL: https://github.com/apache/celeborn/pull/2432#issuecomment-2115012571
Thanks! Merging to main(v0.5.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2432:
URL: https://github.com/apache/celeborn/pull/2432#discussion_r1546249832
##########
client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java:
##########
@@ -106,7 +104,7 @@ public ArrayList<PushTask> takePushTasks() throws IOException, InterruptedExcept
if (loc != null) {
Integer oldCapacity = workerCapacity.get(loc.hostAndPushPort());
if (oldCapacity == null) {
- oldCapacity = maxInFlightPerWorker - pushState.inflightPushes(loc.hostAndPushPort());
+ oldCapacity = pushState.remainingAllowPushes(loc.hostAndPushPort());
Review Comment:
@mcdull-zhang, this changes means that the amount of netty in-flight requests per worker could not be configured, which cause that the user could not control the max amount. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2432:
URL: https://github.com/apache/celeborn/pull/2432#discussion_r1546249832
##########
client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java:
##########
@@ -106,7 +104,7 @@ public ArrayList<PushTask> takePushTasks() throws IOException, InterruptedExcept
if (loc != null) {
Integer oldCapacity = workerCapacity.get(loc.hostAndPushPort());
if (oldCapacity == null) {
- oldCapacity = maxInFlightPerWorker - pushState.inflightPushes(loc.hostAndPushPort());
+ oldCapacity = pushState.remainingAllowPushes(loc.hostAndPushPort());
Review Comment:
This changes means that the amount of netty in-flight requests per worker could not be configured, which cause that the user could not control the amount.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy [celeborn]
Posted by "mcdull-zhang (via GitHub)" <gi...@apache.org>.
mcdull-zhang commented on code in PR #2432:
URL: https://github.com/apache/celeborn/pull/2432#discussion_r1570622570
##########
client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java:
##########
@@ -106,7 +104,7 @@ public ArrayList<PushTask> takePushTasks() throws IOException, InterruptedExcept
if (loc != null) {
Integer oldCapacity = workerCapacity.get(loc.hostAndPushPort());
if (oldCapacity == null) {
- oldCapacity = maxInFlightPerWorker - pushState.inflightPushes(loc.hostAndPushPort());
+ oldCapacity = pushState.remainingAllowPushes(loc.hostAndPushPort());
Review Comment:
https://github.com/apache/celeborn/blob/2c76a6e429d69d010482e149051dd0322e7d9853/common/src/main/java/org/apache/celeborn/common/write/InFlightRequestTracker.java#L104-L119
For a `PushTask` to be actually executed, the number of batchIds being sent should be less than `currentMaxReqsInFlight`, so the `DataPushQueue` should use this threshold to decide whether the PushTask can be dequeued.
Am I understanding this correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1361] MaxInFlightPerWorker should use the value provided by PushStrategy [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2432:
URL: https://github.com/apache/celeborn/pull/2432#discussion_r1574369655
##########
client/src/main/java/org/apache/celeborn/client/write/DataPushQueue.java:
##########
@@ -106,7 +104,7 @@ public ArrayList<PushTask> takePushTasks() throws IOException, InterruptedExcept
if (loc != null) {
Integer oldCapacity = workerCapacity.get(loc.hostAndPushPort());
if (oldCapacity == null) {
- oldCapacity = maxInFlightPerWorker - pushState.inflightPushes(loc.hostAndPushPort());
+ oldCapacity = pushState.remainingAllowPushes(loc.hostAndPushPort());
Review Comment:
cc @RexXiong. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org