You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Lukasz Lenart <lu...@googlemail.com> on 2008/12/02 23:48:52 UTC
[2.1.3-SNAPSHOT] DataTimePicker test issue
Hi,
I'm testing Dojo plugin from IntelliJ IDEA and I'm getting test
failures for DateTimePickerTagTest:
testSimple, testSimpleDisabled, testDateParsing
It happens with such settings:
-Duser.language=pl -Duser.country=PL
If I switch to
-Duser.language=en -Duser.country=EN
everything is ok, could someone confirm that?
I made some changes but still testDateParsing is falling.
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [2.1.3-SNAPSHOT] DataTimePicker test issue
Posted by Lukasz Lenart <lu...@googlemail.com>.
2008/12/3 Lukasz Lenart <lu...@googlemail.com>:
> I just realized that I should prepare some test app ;-)
It looks like it works, I just made simple app with DateTimePickerTag
and it works, I now is not sufficient but that all I can do right now
;-)
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [2.1.3-SNAPSHOT] DataTimePicker test issue
Posted by Lukasz Lenart <lu...@googlemail.com>.
2008/12/3 Musachy Barroso <mu...@gmail.com>:
> thanks for the patch!. Are the changes to the component necessary or
> just the test? Just looking at the diff I don't see the difference in
> behavior.
The changes below solved the problems with this two tests:
testSimple() and testSimpleDisabled()
formats.add(0, displayFormat);
...
return format.format(date);
The test change is needed to solve problem with third test: testDateParsing()
I just realized that I should prepare some test app ;-)
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [2.1.3-SNAPSHOT] DataTimePicker test issue
Posted by dusty <du...@yahoo.com>.
cheer up musachy! You are still the man.
Musachy Barroso wrote:
>
> and my name is in all those Dojo commits in svn. /cry_a_bit
>
> On Wed, Dec 3, 2008 at 4:02 PM, dusty <du...@yahoo.com> wrote:
>>
>> the only patch a dojo component needs is a "rm".
>>
>> Setting the cssClass on the s:textfield and Jquery
>> $(".mydateclass").datepicker(etc . )
>>
>> So easy. So pure. Beautiful.
>>
>>
>> Musachy Barroso wrote:
>>>
>>> thanks for the patch!. Are the changes to the component necessary or
>>> just the test? Just looking at the diff I don't see the difference in
>>> behavior.
>>>
>>> musachy
>>>
>>> On Wed, Dec 3, 2008 at 2:52 PM, Lukasz Lenart
>>> <lu...@googlemail.com> wrote:
>>>> Hi,
>>>>
>>>> I think, I solved the problem, please check
>>>> https://issues.apache.org/struts/browse/WW-2906
>>>>
>>>>
>>>> Regards
>>>> --
>>>> Lukasz
>>>> http://www.lenart.org.pl/
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>>
>>
>> --
>> View this message in context:
>> http://www.nabble.com/-2.1.3-SNAPSHOT--DataTimePicker-test-issue-tp20802830p20821559.html
>> Sent from the Struts - Dev mailing list archive at Nabble.com.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
>
> --
> "Hey you! Would you help me to carry the stone?" Pink Floyd
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
--
View this message in context: http://www.nabble.com/-2.1.3-SNAPSHOT--DataTimePicker-test-issue-tp20802830p20821834.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [2.1.3-SNAPSHOT] DataTimePicker test issue
Posted by Musachy Barroso <mu...@gmail.com>.
and my name is in all those Dojo commits in svn. /cry_a_bit
On Wed, Dec 3, 2008 at 4:02 PM, dusty <du...@yahoo.com> wrote:
>
> the only patch a dojo component needs is a "rm".
>
> Setting the cssClass on the s:textfield and Jquery
> $(".mydateclass").datepicker(etc . )
>
> So easy. So pure. Beautiful.
>
>
> Musachy Barroso wrote:
>>
>> thanks for the patch!. Are the changes to the component necessary or
>> just the test? Just looking at the diff I don't see the difference in
>> behavior.
>>
>> musachy
>>
>> On Wed, Dec 3, 2008 at 2:52 PM, Lukasz Lenart
>> <lu...@googlemail.com> wrote:
>>> Hi,
>>>
>>> I think, I solved the problem, please check
>>> https://issues.apache.org/struts/browse/WW-2906
>>>
>>>
>>> Regards
>>> --
>>> Lukasz
>>> http://www.lenart.org.pl/
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>>
>>
>> --
>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>
> --
> View this message in context: http://www.nabble.com/-2.1.3-SNAPSHOT--DataTimePicker-test-issue-tp20802830p20821559.html
> Sent from the Struts - Dev mailing list archive at Nabble.com.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [2.1.3-SNAPSHOT] DataTimePicker test issue
Posted by dusty <du...@yahoo.com>.
the only patch a dojo component needs is a "rm".
Setting the cssClass on the s:textfield and Jquery
$(".mydateclass").datepicker(etc . )
So easy. So pure. Beautiful.
Musachy Barroso wrote:
>
> thanks for the patch!. Are the changes to the component necessary or
> just the test? Just looking at the diff I don't see the difference in
> behavior.
>
> musachy
>
> On Wed, Dec 3, 2008 at 2:52 PM, Lukasz Lenart
> <lu...@googlemail.com> wrote:
>> Hi,
>>
>> I think, I solved the problem, please check
>> https://issues.apache.org/struts/browse/WW-2906
>>
>>
>> Regards
>> --
>> Lukasz
>> http://www.lenart.org.pl/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
>
> --
> "Hey you! Would you help me to carry the stone?" Pink Floyd
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
--
View this message in context: http://www.nabble.com/-2.1.3-SNAPSHOT--DataTimePicker-test-issue-tp20802830p20821559.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [2.1.3-SNAPSHOT] DataTimePicker test issue
Posted by Musachy Barroso <mu...@gmail.com>.
thanks for the patch!. Are the changes to the component necessary or
just the test? Just looking at the diff I don't see the difference in
behavior.
musachy
On Wed, Dec 3, 2008 at 2:52 PM, Lukasz Lenart
<lu...@googlemail.com> wrote:
> Hi,
>
> I think, I solved the problem, please check
> https://issues.apache.org/struts/browse/WW-2906
>
>
> Regards
> --
> Lukasz
> http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [2.1.3-SNAPSHOT] DataTimePicker test issue
Posted by Lukasz Lenart <lu...@googlemail.com>.
Hi,
I think, I solved the problem, please check
https://issues.apache.org/struts/browse/WW-2906
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [2.1.3-SNAPSHOT] DataTimePicker test issue
Posted by Lukasz Lenart <lu...@googlemail.com>.
2008/12/2 Musachy Barroso <mu...@gmail.com>:
>> I made some changes but still testDateParsing is falling.
>>
>
> How is it failing? This line look suspicious to me:
junit.framework.AssertionFailedError: expected:<2007> but was:<2019>
after my change
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [2.1.3-SNAPSHOT] DataTimePicker test issue
Posted by Musachy Barroso <mu...@gmail.com>.
> I made some changes but still testDateParsing is falling.
>
How is it failing? This line look suspicious to me:
"stack.set("date", "01-01-2007");"
//we should deprecate the dojo plugin before 2.1 goes GA
musachy
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org