You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by fe...@apache.org on 2016/02/27 06:54:05 UTC
incubator-zeppelin git commit: Add PR template for github
Repository: incubator-zeppelin
Updated Branches:
refs/heads/master d5d918f52 -> bb89b6e0e
Add PR template for github
### What is this PR for?
PR template can be added automatically by GitHub when a PR is opened.
https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/
Proposing some changes to PR template wordings.
### What type of PR is it?
Improvement
### Todos
* [x] - Add template
### Is there a relevant Jira issue?
N/A
### How should this be tested?
Open a new PR.
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
Author: Felix Cheung <fe...@hotmail.com>
Closes #748 from felixcheung/prtemplate and squashes the following commits:
9280ba7 [Felix Cheung] update contributing.md
aa56917 [Felix Cheung] add rat exclude to the right list
4a14447 [Felix Cheung] fix rat
5d5e067 [Felix Cheung] move
4360a47 [Felix Cheung] move to .github
43f9418 [Felix Cheung] format update
045308a [Felix Cheung] jira link
60e361b [Felix Cheung] add template
Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/bb89b6e0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/bb89b6e0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/bb89b6e0
Branch: refs/heads/master
Commit: bb89b6e0e473130d88921b5a259e60b1ca499bfb
Parents: d5d918f
Author: Felix Cheung <fe...@hotmail.com>
Authored: Thu Feb 25 14:15:11 2016 -0800
Committer: Felix Cheung <fe...@apache.org>
Committed: Fri Feb 26 21:54:02 2016 -0800
----------------------------------------------------------------------
.github/PULL_REQUEST_TEMPLATE | 24 ++++++++++++++++++++++++
CONTRIBUTING.md | 11 ++++-------
pom.xml | 1 +
3 files changed, 29 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/bb89b6e0/.github/PULL_REQUEST_TEMPLATE
----------------------------------------------------------------------
diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE
new file mode 100644
index 0000000..322b691
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE
@@ -0,0 +1,24 @@
+### What is this PR for?
+A few sentences describing the overall goals of the pull request's commits.
+First time? Check out the contributing guide - https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md
+
+
+### What type of PR is it?
+[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
+
+### Todos
+* [ ] - Task
+
+### What is the Jira issue?
+* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
+* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
+
+### How should this be tested?
+Outline the steps to test the PR here.
+
+### Screenshots (if appropriate)
+
+### Questions:
+* Does the licenses files need update?
+* Is there breaking changes for older versions?
+* Does this needs documentation?
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/bb89b6e0/CONTRIBUTING.md
----------------------------------------------------------------------
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 27c4ef6..f0eb97c 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -17,6 +17,7 @@ In order to make the review process easier, please follow this template when mak
```
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
+First time? Check out the contributing guide - https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
@@ -24,7 +25,9 @@ A few sentences describing the overall goals of the pull request's commits.
### Todos
* [ ] - Task
-### Is there a relevant Jira issue?
+### What is the Jira issue?
+* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
+* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
Outline the steps to test the PR here.
@@ -37,12 +40,6 @@ Outline the steps to test the PR here.
* Does this needs documentation?
```
-You can also use this small bookmarklet tool to fill your Pull Request fields automatically:
-
-```
-javascript:(function() {var e = document.getElementById('pull_request_body');if (e) {e.value += '### What is this PR for?\nA few sentences describing the overall goals of the pull request\'s commits.\n\n### What type of PR is it?\n[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]\n\n### Todos\n* [ ] - Task\n\n### Is there a relevant Jira issue?\n\n### How should this be tested?\nOutline the steps to test the PR here.\n\n### Screenshots (if appropriate)\n\n### Questions:\n* Does the licenses files need update?\n* Is there breaking changes for older versions?\n* Does this needs documentation?';}})();
-```
-
## Testing a Pull Request
You can also test and review a particular Pull Request. Here are two useful ways.
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/bb89b6e0/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 3f74148..ceb1ce9 100755
--- a/pom.xml
+++ b/pom.xml
@@ -446,6 +446,7 @@
<exclude>**/.idea/</exclude>
<exclude>**/*.iml</exclude>
<exclude>.git/</exclude>
+ <exclude>.github/*</exclude>
<exclude>.gitignore</exclude>
<exclude>.repository/</exclude>
<exclude>**/*.diff</exclude>