[jira] [Comment Edited] (SUREFIRE-1765) target/test-classes should not be added to classpath when tests run on modulepath using patch-module

["Tibor Digana (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070865#comment-17070865 ] 

Tibor Digana edited comment on SUREFIRE-1765 at 3/30/20, 10:38 AM:
-------------------------------------------------------------------

[~tomdw]
We have supposed that the modularity in {{src/test/java}} would be useless for developer, and the only modularity needed should be in the {{src/main/java}}.
Pls comment on this!


was (Author: tibor17):
We have supposed that the modularity in {{src/test/java}} would useless for developer, and the only modularity needed should be in the {{src/main/java}}.

> target/test-classes should not be added to classpath when tests run on modulepath using patch-module
> ----------------------------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1765
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1765
>             Project: Maven Surefire
>          Issue Type: Bug
>    Affects Versions: 2.22.1, 2.22.2
>            Reporter: Tom De Wolf
>            Priority: Major
>
> When running junit tests using the maven-surefire-plugin the target/test-classes are added as first entry in the classpath.
> However, when testing a explicit java module with a module-info.java the test-classes are already part of the module path using --patch-module. So they should not be on the classpath?
> In some scenario's this can give unwanted side-effects, i.e. that the same classes are on the modulepath and classpath, possibly with a module-info.class in both locations (cfr [https://bugs.openjdk.java.net/browse/JDK-8241770).]
> So it seems that it is best that target/test-classes is only added to the classpath when it is not put on the module-path.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)