[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #7469: Core, Spark: Add configuration to control case sensitivity of CachingCatalog

["RussellSpitzer (via GitHub)" <gi...@apache.org>]

RussellSpitzer commented on code in PR #7469:
URL: https://github.com/apache/iceberg/pull/7469#discussion_r1181967223


##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -41,6 +41,11 @@ private CatalogProperties() {}
 
   public static final boolean CACHE_ENABLED_DEFAULT = true;
 
+  /** Controls whether the caching catalog will cache table entries using case-sensitive keys. */
+  public static final String CACHE_CASE_SENSITIVE = "cache.case-sensitive";
+
+  public static final boolean CACHE_CASE_SENSITIVE_DEFAULT = false;

Review Comment:
   Should we match the spark sql case sensitivity patan?



##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -41,6 +41,11 @@ private CatalogProperties() {}
 
   public static final boolean CACHE_ENABLED_DEFAULT = true;
 
+  /** Controls whether the caching catalog will cache table entries using case-sensitive keys. */
+  public static final String CACHE_CASE_SENSITIVE = "cache.case-sensitive";
+
+  public static final boolean CACHE_CASE_SENSITIVE_DEFAULT = false;

Review Comment:
   Should we match the spark sql case sensitivity param



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org