You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/25 12:55:51 UTC
[GitHub] [spark] otterc commented on a change in pull request #33034: [SPARK-32923][CORE][SHUFFLE] Handle indeterminate stage retries for push-based shuffle
otterc commented on a change in pull request #33034:
URL: https://github.com/apache/spark/pull/33034#discussion_r676142336
##########
File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java
##########
@@ -380,9 +381,10 @@ protected Ratio getRatio() {
} else if (blockId0Parts.length == 4 && blockId0Parts[0].equals(SHUFFLE_CHUNK_ID)) {
Review comment:
There are existing tests ` testFetchMergedBlocksMeta`, `testOpenBlocksWithShuffleChunks` and `testFetchShuffleChunks`, ... which should be updated. Right now the tests don't even compile
```
info] compiling 42 Java sources to /home/runner/work/spark/spark/common/network-shuffle/target/scala-2.12/classes ...
[error] /home/runner/work/spark/spark/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:162:1: error: ';' expected
[error] shuffleMergeId, appShuffleInfo.appId, appShuffleInfo.attemptId));
[error] ^
[error] /home/runner/work/spark/spark/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:177:1: error: ';' expected
[error] appShuffleInfo.appId, appShuffleInfo.attemptId, latestShuffleMergeId));
[error] ^
[error] /home/runner/work/spark/spark/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:189:1: error: ';' expected
[error] latestShuffleMergeId));
[error] ^3 errors
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org