You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by swegner <gi...@git.apache.org> on 2016/04/26 17:59:17 UTC
[GitHub] incubator-beam pull request: [BEAM-117] Minor updates for DisplayD...
GitHub user swegner opened a pull request:
https://github.com/apache/incubator-beam/pull/241
[BEAM-117] Minor updates for DisplayData usage
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This PR addresses the following JIRA issues:
* [[BEAM-195] Rename DisplayDataMatchers#includes](https://issues.apache.org/jira/browse/BEAM-195)
* [[BEAM-200] Standardize terminology to "display data" in documentation](https://issues.apache.org/jira/browse/BEAM-200)
* [[BEAM-219] Use super.populateDisplayData consistently](https://issues.apache.org/jira/browse/BEAM-219)
[[BEAM-199] Improve fluent interface for manipulating DisplayData.Items](https://issues.apache.org/jira/browse/BEAM-199) will be in the next PR as to not bloat this one too much.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swegner/incubator-beam displaydata-tweaks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #241
----
commit 08b475f1971b3f74c9b321941cdbe2818c25c939
Author: Scott Wegner <sw...@google.com>
Date: 2016-04-25T16:31:13Z
Rename DisplayDataMatchers.includes to includesDisplayData to clarify usage
commit 5a1d93ce01000df8577acd66d6e9c6ebf5d6948f
Author: Scott Wegner <sw...@google.com>
Date: 2016-04-25T16:34:58Z
Normalize comments to refer to 'display data' rather than 'display metadata'
commit 954e734fbde4a055ee97d84b9f1c91d598fc5de9
Author: Scott Wegner <sw...@google.com>
Date: 2016-04-25T16:41:07Z
Add super.populateDisplayData() to standard implementations. The current super implementation is a no-op, but this is the recommended way to implement the pattern
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request: [BEAM-117] Minor updates for DisplayD...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/241
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---