You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/07/10 09:36:33 UTC

Review Request 12432: Added os::Fork for declaring and instantiating process trees.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12432/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos


Description
-------

See summary.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 864b30ea5661cc7f613fdd422fe55f76fdafd1c1 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 429039644832470f7fd2eac19b213905cc81dcd3 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 88a936e19342b1891e4b39c42bdaaa45603fda50 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 6a11b018f83651be20026850aeb7cf08d7c85b2f 

Diff: https://reviews.apache.org/r/12432/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Re: Review Request 12432: Added os::Fork for declaring and instantiating process trees.

Posted by Benjamin Hindman <be...@berkeley.edu>.


> On Aug. 2, 2013, 8:53 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp, line 97
> > <https://reviews.apache.org/r/12432/diff/1/?file=319793#file319793line97>
> >
> >     Why is the function not an Option here, like the rest of the constructors?

Thanks!


> On Aug. 2, 2013, 8:53 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp, line 208
> > <https://reviews.apache.org/r/12432/diff/1/?file=319793#file319793line208>
> >
> >     s/it's/its/
> >     s/descendants/descendants'/

Muchos thanks!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12432/#review23322
-----------------------------------------------------------


On July 10, 2013, 7:36 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12432/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 7:36 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 864b30ea5661cc7f613fdd422fe55f76fdafd1c1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 429039644832470f7fd2eac19b213905cc81dcd3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 88a936e19342b1891e4b39c42bdaaa45603fda50 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 6a11b018f83651be20026850aeb7cf08d7c85b2f 
> 
> Diff: https://reviews.apache.org/r/12432/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 12432: Added os::Fork for declaring and instantiating process trees.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12432/#review23322
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp
<https://reviews.apache.org/r/12432/#comment47204>

    Why is the function not an Option here, like the rest of the constructors?



3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp
<https://reviews.apache.org/r/12432/#comment47205>

    s/it's/its/
    s/descendants/descendants'/



3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp
<https://reviews.apache.org/r/12432/#comment47825>

    Did you want to hide prepare() and instantiate()?



3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
<https://reviews.apache.org/r/12432/#comment47824>

    Sooooo much nicer!


- Ben Mahler


On July 10, 2013, 7:36 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12432/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 7:36 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 864b30ea5661cc7f613fdd422fe55f76fdafd1c1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 429039644832470f7fd2eac19b213905cc81dcd3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 88a936e19342b1891e4b39c42bdaaa45603fda50 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 6a11b018f83651be20026850aeb7cf08d7c85b2f 
> 
> Diff: https://reviews.apache.org/r/12432/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 12432: Added os::Fork for declaring and instantiating process trees.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12432/#review24562
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On July 10, 2013, 7:36 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12432/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 7:36 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 864b30ea5661cc7f613fdd422fe55f76fdafd1c1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 429039644832470f7fd2eac19b213905cc81dcd3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 88a936e19342b1891e4b39c42bdaaa45603fda50 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 6a11b018f83651be20026850aeb7cf08d7c85b2f 
> 
> Diff: https://reviews.apache.org/r/12432/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>