(datafusion) branch gh-readonly-queue/main/pr-23129-e7349e5744ef42c47db9eec110db51a63f0e13f7 created (now 30d944c5c1)

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-23129-e7349e5744ef42c47db9eec110db51a63f0e13f7
in repository https://gitbox.apache.org/repos/asf/datafusion.git


      at 30d944c5c1 chore(datasource): remove deprecated `create_writer` free function (Closes #23080 — partial) (#23129)

This branch includes the following new commits:

     new 30d944c5c1 chore(datasource): remove deprecated `create_writer` free function (Closes #23080 — partial) (#23129)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org

(datafusion) 01/01: chore(datasource): remove deprecated `create_writer` free function (Closes #23080 — partial) (#23129)

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-23129-e7349e5744ef42c47db9eec110db51a63f0e13f7
in repository https://gitbox.apache.org/repos/asf/datafusion.git

commit 30d944c5c161128c63c968de88bdb226b5450669
Author: Giorgio Maria Federico Birnthaler <12...@users.noreply.github.com>
AuthorDate: Tue Jun 23 20:50:05 2026 +0200

    chore(datasource): remove deprecated `create_writer` free function (Closes #23080 — partial) (#23129)
    
    ## Summary
    
    Removes the free function `datafusion_datasource::write::create_writer`,
    which was deprecated in 48.0.0 with the suggestion to use
    `ObjectWriterBuilder::new(...)` instead. Per the [API health deprecation
    guidelines](https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines),
    APIs deprecated in 48.0.0 or earlier are now eligible for removal.
    
    A grep across the workspace confirms `create_writer` has **zero
    callers** anywhere in the repo (the other matches are differently-named
    methods `create_writer_physical_plan` and `create_writer_props`, which
    we are not touching) and is not re-exported from
    `datafusion_datasource::lib`. This is the smallest possible pure-removal
    cleanup — 16 lines deleted from a single file.
    
    Part of  #23080 (partial — one of the listed eligible items).
    
    ## Test plan
    
    ```
    git diff upstream/main..chore/remove-deprecated-create-writer
     datafusion/datasource/src/write/mod.rs | 16 ----------------
     1 file changed, 16 deletions(-)
    ```
    
    Since all callers are gone, no test updates are needed; the standard CI
    matrix (`./dev/rust_lint.sh`, `cargo check -p datafusion-datasource`,
    downstream consumer builds) will catch any indirect breakage.
    
    ## AI assistance
    
    Used an AI coding assistant to identify and minimally remove the unused
    deprecated function. I read the file end-to-end before and after the
    diff, verified zero callers via a workspace grep, and the change is a
    16-line pure deletion.
---
 datafusion/datasource/src/write/mod.rs | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/datafusion/datasource/src/write/mod.rs b/datafusion/datasource/src/write/mod.rs
index e8d2d17da8..c8c85112f0 100644
--- a/datafusion/datasource/src/write/mod.rs
+++ b/datafusion/datasource/src/write/mod.rs
@@ -75,22 +75,6 @@ pub trait BatchSerializer: Sync + Send {
     fn serialize(&self, batch: RecordBatch, initial: bool) -> Result<Bytes>;
 }
 
-/// Returns an [`AsyncWrite`] which writes to the given object store location
-/// with the specified compression.
-///
-/// The writer will have a default buffer size as chosen by [`BufWriter::new`].
-///
-/// We drop the `AbortableWrite` struct and the writer will not try to cleanup on failure.
-/// Users can configure automatic cleanup with their cloud provider.
-#[deprecated(since = "48.0.0", note = "Use ObjectWriterBuilder::new(...) instead")]
-pub async fn create_writer(
-    file_compression_type: FileCompressionType,
-    location: &Path,
-    object_store: Arc<dyn ObjectStore>,
-) -> Result<Box<dyn AsyncWrite + Send + Unpin>> {
-    ObjectWriterBuilder::new(file_compression_type, location, object_store).build()
-}
-
 /// Converts table schema to writer schema, which may differ in the case
 /// of hive style partitioning where some columns are removed from the
 /// underlying files.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org