You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by mi...@apache.org on 2026/05/06 18:12:37 UTC
(impala) branch master updated (042b915c9 -> 325dc8b26)
This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
from 042b915c9 IMPALA-14804: Improve incremental refresh of Iceberg tables
new 1445b7e33 IMPALA-14948: Fix missing vim-common in bootstrap_build.sh
new 325dc8b26 [tools] Improve Dev Container support
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.devcontainer/Dockerfile | 3 ++-
.devcontainer/devcontainer.json | 6 +++++-
bin/bootstrap_build.sh | 9 +++++----
3 files changed, 12 insertions(+), 6 deletions(-)
(impala) 02/02: [tools] Improve Dev Container support
Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 325dc8b266ae94318f84b787901e6fe80305eae8
Author: stiga-huang <hu...@gmail.com>
AuthorDate: Mon May 4 08:39:43 2026 +0800
[tools] Improve Dev Container support
This patches improve the Dev Container support for VSCode/Cursor:
- Install clangd-12 as the language server for C++.
- Add limits on cpu and memory for the container.
- Forward ports of the container for minicluster services.
- Start postgresql when launching the container.
Change-Id: I29f1709c4ce9b42d213cc48c4f6f718d8a8ea159
Reviewed-on: http://gerrit.cloudera.org:8080/24266
Reviewed-by: Jason Fehr <jf...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
.devcontainer/Dockerfile | 3 ++-
.devcontainer/devcontainer.json | 6 +++++-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
index 8cb17a547..da57788b7 100644
--- a/.devcontainer/Dockerfile
+++ b/.devcontainer/Dockerfile
@@ -4,7 +4,8 @@ ARG USER_UID=1000
ARG USER_GID=$USER_UID
RUN apt-get update \
- && apt-get install -y sudo git \
+ && apt-get install -y sudo git clangd-12 \
+ && update-alternatives --install /usr/bin/clangd clangd /usr/bin/clangd-12 100 \
&& addgroup --gid "${USER_GID}" impdev \
&& adduser --uid "${USER_UID}" --gid "${USER_GID}" --disabled-password --gecos '' impdev \
&& echo 'impdev ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers
\ No newline at end of file
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index 39ce649a2..a4a164df1 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -2,11 +2,15 @@
"name": "Impala Dev",
"dockerFile": "Dockerfile",
"runArgs": [
- "--privileged"
+ "--privileged",
+ "--cpu=8",
+ "--memory=20g"
],
"remoteUser": "impdev",
"containerUser": "impdev",
+ "forwardPorts": [5070, 6080, 8051, 8088, 10001, 25000, 25001, 25002, 25010, 25020],
"postCreateCommand": "echo 'yes' | bin/bootstrap_development.sh",
+ "postStartCommand": "sudo service postgresql start",
"customizations": {
"vscode": {
"extensions": [
(impala) 01/02: IMPALA-14948: Fix missing vim-common in bootstrap_build.sh
Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 1445b7e33fb60fd4dbbdbb1e6ec88a414fe1b21f
Author: stiga-huang <hu...@gmail.com>
AuthorDate: Sun May 3 14:45:45 2026 +0800
IMPALA-14948: Fix missing vim-common in bootstrap_build.sh
Running bin/bootstrap_build.sh in a Docker container based on Ubuntu
20.04 failed with "xxd: command not found". The cause is vim-common is
not installed in the script. Note that bin/bootstrap_system.sh installs
this dependency so it's fine.
This adds the missing dependency in boostrap_build.sh. Also removes -so
in the build option since it's rarely used now. Adds -noclean build
option to be consistent with our daily usage.
Adds -f to the ln command of adding maven to be consistent with
bootstrap_system.sh.
Tests
- Manually tested the script in a local container.
Change-Id: Ic43dcf4cba5370c25db62d70e0704b410a4016b8
Reviewed-on: http://gerrit.cloudera.org:8080/24265
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Reviewed-by: Daniel Vanko <dv...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
bin/bootstrap_build.sh | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/bin/bootstrap_build.sh b/bin/bootstrap_build.sh
index 7da5bf75d..44b289515 100755
--- a/bin/bootstrap_build.sh
+++ b/bin/bootstrap_build.sh
@@ -21,7 +21,7 @@
# 22.04 and 24.04. To run it you need to have:
#
# 1. At least 8GB of free disk space
-# 4. A connection to the internet (parts of the build download dependencies)
+# 2. A connection to the internet (parts of the build download dependencies)
#
# To bootstrap a more complete development environment that includes not only building
# Impala but also running and testing it, see bootstrap_development.sh in this directory.
@@ -36,7 +36,8 @@ sudo -E apt-get --quiet update
# Always install Python 3 and set it to be the default Python
PACKAGES='g++ gcc git libsasl2-dev libssl-dev make ninja-build
python3-dev python3-setuptools python3-venv libffi-dev language-pack-en
- libkrb5-dev krb5-admin-server krb5-kdc krb5-user libxml2-dev libxslt-dev wget'
+ libkrb5-dev krb5-admin-server krb5-kdc krb5-user libxml2-dev libxslt-dev wget
+ vim-common'
sudo -E apt-get --yes --quiet install ${PACKAGES}
@@ -57,7 +58,7 @@ if [ ! -d "/usr/local/apache-maven-${MVN_VERSION}" ]; then
"https://${IMPALA_TOOLCHAIN_HOST}/maven/apache-maven-${MVN_VERSION}-bin.tar.gz"
sha512sum -c - <<< "33d81e0ec785f0207e3e5e3ffb61863e1dca5784c15ac3fb5ff105f69cffbea484eb8d473ea60467a63f7b0570eef8622f2fed8eee96acbe668aa313391cddb3 apache-maven-${MVN_VERSION}-bin.tar.gz"
sudo tar -C /usr/local -xzf apache-maven-${MVN_VERSION}-bin.tar.gz
- sudo ln -s /usr/local/apache-maven-${MVN_VERSION}/bin/mvn /usr/local/bin
+ sudo ln -s -f /usr/local/apache-maven-${MVN_VERSION}/bin/mvn /usr/local/bin
fi
# Optionally try to prepopulate the m2 directory to save time. Since Maven has
@@ -71,4 +72,4 @@ else
echo ">>> Skip populating m2 directory"
fi
-./buildall.sh -notests -so
+./buildall.sh -notests -noclean