You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "xleoken (via GitHub)" <gi...@apache.org> on 2024/04/22 07:06:36 UTC
[PR] [AMORO-2776] Keeping the folder name the same with the artifactId in amoro-mixed-format module [amoro]
xleoken opened a new pull request, #2777:
URL: https://github.com/apache/amoro/pull/2777
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
Change the folder name of the module to match the artifactId
Close #2776.
## Brief change log
Keeping the folder name the same with the artifactId in amoro-mixed-format module.
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-2776] Keeping the folder name the same with the artifactId in amoro-mixed-format module [amoro]
Posted by "xleoken (via GitHub)" <gi...@apache.org>.
xleoken commented on PR #2777:
URL: https://github.com/apache/amoro/pull/2777#issuecomment-2068679904
cc @zhoujinsong @zhongqishang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-2776] Keeping the folder name the same with the artifactId in amoro-mixed-format module [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #2777:
URL: https://github.com/apache/amoro/pull/2777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-2776] Keeping the folder name the same with the artifactId in amoro-mixed-format module [amoro]
Posted by "zhongqishang (via GitHub)" <gi...@apache.org>.
zhongqishang commented on code in PR #2777:
URL: https://github.com/apache/amoro/pull/2777#discussion_r1575558691
##########
docs/admin-guides/deployment.md:
##########
@@ -35,23 +35,23 @@ You can build based on the master branch without compiling Trino. The compilatio
git clone https://github.com/apache/amoro.git
cd amoro
base_dir=$(pwd)
-mvn clean package -DskipTests -pl '!mixed-format/trino'
-cd ams/dist/target/
+mvn clean package -DskipTests -pl '!amoro-mixed-format/amoro-mixed-format-trino'
+cd amoro-ams/dist/target/
ls
amoro-x.y.z-bin.zip # AMS release package
dist-x.y.z-tests.jar
dist-x.y.z.jar
archive-tmp/
maven-archiver/
-cd ${base_dir}/mixed-format/flink/v1.15/flink-runtime/target
+cd ${base_dir}/amoro-mixed-format/amoro-mixed-format-flink/v1.15/amoro-mixed-format-flink-1.15/target
Review Comment:
```suggestion
cd ${base_dir}/amoro-mixed-format/amoro-mixed-format-flink/v1.15/amoro-mixed-format-flink-runtime-1.15/target
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-2776] Keeping the folder name the same with the artifactId in amoro-mixed-format module [amoro]
Posted by "xleoken (via GitHub)" <gi...@apache.org>.
xleoken commented on PR #2777:
URL: https://github.com/apache/amoro/pull/2777#issuecomment-2071216433
> There are paths used in [deployment.md](https://github.com/apache/amoro/blob/master/docs/admin-guides/deployment.md), Need to be changed together.
Make sense, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org