You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/05 19:53:06 UTC

[GitHub] [airflow] Hasan-J commented on a change in pull request #10192: Deprecate BaseHook.get_connections method (#10135)

Hasan-J commented on a change in pull request #10192:
URL: https://github.com/apache/airflow/pull/10192#discussion_r465965967



##########
File path: airflow/hooks/base_hook.py
##########
@@ -44,17 +44,21 @@ def get_connections(cls, conn_id: str) -> List[Connection]:
         :param conn_id: connection id
         :return: array of connections
         """
+        warnings.warn(
+            "This method is deprecated. Please use `airflow.hooks.base_hook.BaseHook.get_connection`.",
+            DeprecationWarning
+        )
         return secrets.get_connections(conn_id)

Review comment:
       So, this is the only change we needed!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org