[bookkeeper] branch branch-4.7 updated: [TABLE SERVICE] Improve logging message on initializing table range stores.

[si...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch branch-4.7
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/branch-4.7 by this push:
     new 8a3cd14  [TABLE SERVICE] Improve logging message on initializing table range stores.
8a3cd14 is described below

commit 8a3cd14a1950278ea2592c91fed6a873dda1c4b9
Author: Sijie Guo <si...@apache.org>
AuthorDate: Wed Jun 6 23:02:52 2018 -0700

    [TABLE SERVICE] Improve logging message on initializing table range stores.
    
    Descriptions of the changes in this PR:
    
    *Motivation*
    
    Exceptions might be throwing on starting/stopping table ranges. It would be good to have logging messages about the state transition for debugging purpose.
    
    *Build*
    
    Only touch following stream modules, skip bookkeeper-server related tests:
    
    [skip tests]
    
    Author: Sijie Guo <si...@apache.org>
    
    Reviewers: Enrico Olivelli <eo...@gmail.com>, Jia Zhai <None>
    
    This closes #1493 from sijie/improve_logging
    
    (cherry picked from commit 798e6b8f3f26d55eef7ee50e8a4abe12db477e57)
    Signed-off-by: Sijie Guo <si...@apache.org>
---
 .../stream/storage/impl/store/MVCCStoreFactoryImpl.java          | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/stream/storage/impl/src/main/java/org/apache/bookkeeper/stream/storage/impl/store/MVCCStoreFactoryImpl.java b/stream/storage/impl/src/main/java/org/apache/bookkeeper/stream/storage/impl/store/MVCCStoreFactoryImpl.java
index 28f9955..6f01d4b 100644
--- a/stream/storage/impl/src/main/java/org/apache/bookkeeper/stream/storage/impl/store/MVCCStoreFactoryImpl.java
+++ b/stream/storage/impl/src/main/java/org/apache/bookkeeper/stream/storage/impl/store/MVCCStoreFactoryImpl.java
@@ -136,8 +136,8 @@ public class MVCCStoreFactoryImpl implements MVCCStoreFactory {
         if (null != oldStore) {
             store.closeAsync();
         } else {
-            log.info("Add store (scId = {}, streamId = {}, rangeId = {})",
-                scId, streamId, rangeId);
+            log.info("Add store (scId = {}, streamId = {}, rangeId = {}) at storage container ({})",
+                scId, streamId, rangeId, scId);
             scStores.put(rid, store);
         }
     }
@@ -169,6 +169,9 @@ public class MVCCStoreFactoryImpl implements MVCCStoreFactory {
             }
         }
 
+        log.info("Initializing stream({})/range({}) at storage container ({})",
+            streamId, rangeId, scId);
+
         MVCCAsyncStore<byte[], byte[]> store = storeSupplier.get();
 
         File targetDir = chooseLocalStoreDir(streamId);
@@ -205,6 +208,8 @@ public class MVCCStoreFactoryImpl implements MVCCStoreFactory {
             .build();
 
         return store.init(spec).thenApply(ignored -> {
+            log.info("Successfully initialize stream({})/range({}) at storage container ({})",
+                streamId, rangeId, scId);
             addStore(scId, streamId, rangeId, store);
             return store;
         });

-- 
To stop receiving notification emails like this one, please contact
sijie@apache.org.