You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/05/06 07:22:32 UTC
[GitHub] [echarts] plainheart opened a new issue #14875: [Perf] High CPU overload and user interaction freezed in SVG map (canvas & svg)
plainheart opened a new issue #14875:
URL: https://github.com/apache/echarts/issues/14875
### Version
5.1.1
### Reproduction link
https://echarts.apache.org/examples/zh/editor.html?c=geo-svg-scatter-simple
### Steps to reproduce
- Open the reproduction link
- Watch the CPU overload in default `canvas` renderer
- Switch to `svg` renderer
- Watch the CPU overload and effectScatter rendering
- The effectScatter's animation becomes not smooth any more
### What is expected?
Lower CPU overload and effectScatter has a smooth animation
### What is actually happening?
High CPU overload and the animation of effectScatter is not smooth.
### Others
**I noticed that a strange zrender level named `zr_100000` was added to the DOM.**
<!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
<!-- This issue is in English. DO NOT REMOVE -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on issue #14875: [Perf] High CPU overload and user interaction freezed in SVG map (canvas & svg)
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #14875:
URL: https://github.com/apache/echarts/issues/14875#issuecomment-938308036
Seems the performances have been improved in the new SVG renderer https://github.com/ecomfe/zrender/pull/836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on issue #14875: [Perf] High CPU overload and user interaction freezed in SVG map (canvas & svg)
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #14875:
URL: https://github.com/apache/echarts/issues/14875#issuecomment-833301070
@plainheart
`zr_100000` is a special `zlevel` that provided to the hover layer.
SVG rendering mode is not good at animation performance because each frame it will manipulate the attributes of DOM. Even if we did lots of optimizations, it's still not as fast as Canvas. Especially in a case like this map which has lots of elements. The advance of SVG rendering mode is reducing the memory usage on mobile devices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #14875: [Perf] High CPU overload and user interaction freezed in SVG map (canvas & svg)
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #14875:
URL: https://github.com/apache/echarts/issues/14875#issuecomment-938424716
Awesome! The performance got improved significantly. It can be closed later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on issue #14875: [Perf] High CPU overload and user interaction freezed in SVG map (canvas & svg)
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #14875:
URL: https://github.com/apache/echarts/issues/14875#issuecomment-833305249
I profiled this case, it seems `getDefs` method takes lots of time, which I didn't expect.
Perhaps it still has some chance to do more optimization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #14875: [Perf] High CPU overload and user interaction freezed in SVG map (canvas & svg)
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #14875:
URL: https://github.com/apache/echarts/issues/14875#issuecomment-833305021
@pissang Thanks for the detailed explanation. So this should not be considered a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on issue #14875: [Perf] High CPU overload and user interaction freezed in SVG map (canvas & svg)
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #14875:
URL: https://github.com/apache/echarts/issues/14875#issuecomment-833301070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on issue #14875: [Perf] High CPU overload and user interaction freezed in SVG map (canvas & svg)
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #14875:
URL: https://github.com/apache/echarts/issues/14875#issuecomment-833305249
I profiled this case, it seems `getDefs` method takes lots of time, which is not expected.
Perhaps it still has some chance to do more optimization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on issue #14875: [Perf] High CPU overload and user interaction freezed in SVG map (canvas & svg)
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #14875:
URL: https://github.com/apache/echarts/issues/14875#issuecomment-833305249
I profiled this case, it seems `getDefs` method takes lots of time, which I didn't expected.
Perhaps it still has some chance to do more optimization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on issue #14875: [Perf] High CPU overload and user interaction freezed in SVG map (canvas & svg)
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #14875:
URL: https://github.com/apache/echarts/issues/14875#issuecomment-833301070
@plainheart
`zr_100000` is a special `zlevel` that provided to the hover layer.
SVG rendering mode is not good at animation performance because each frame it needs to find out which DOM needs to be updated and manipulate the attributes of DOM. Even if we did lots of optimizations, it's still not as fast as Canvas. Especially in a case like this map which has lots of elements. The advance of SVG rendering mode is reducing the memory usage on mobile devices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on issue #14875: [Perf] High CPU overload and user interaction freezed in SVG map (canvas & svg)
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #14875:
URL: https://github.com/apache/echarts/issues/14875#issuecomment-833305249
After profiling this case, it seems `getDefs` method takes lots of time, which I didn't expect.
Perhaps it still has some chance to do more optimization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang closed issue #14875: [Perf] High CPU overload and user interaction freezed in SVG map (canvas & svg)
Posted by GitBox <gi...@apache.org>.
pissang closed issue #14875:
URL: https://github.com/apache/echarts/issues/14875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org