You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/12 07:14:34 UTC

[GitHub] timifasubaa opened a new pull request #4405: Disable user access request

timifasubaa opened a new pull request #4405: Disable user access request
URL: https://github.com/apache/incubator-superset/pull/4405
 
 
   The request access feature isn't fully implemented and it can potentially be misleading to users who click the access request button and expect to gain access eventually. This PR makes the access request button optional via a feature flag that allows it by default. 
   
   If you set the flag to false, you'll no longer see the image below whenever you don't have access to any of the slices in a dashboard. 
   <img width="1216" alt="no_access_" src="https://user-images.githubusercontent.com/30888507/36086390-eaa59808-0f80-11e8-8568-86500110bcdc.png">
   
   Instead, you'll see all the slices and an error message for any one you don't have access to. Like in the image below. 
   <img width="1087" alt="screen shot 2018-02-11 at 11 13 09 pm" src="https://user-images.githubusercontent.com/30888507/36086447-4bb56de4-0f81-11e8-9941-9a0e4254bf43.png">
   
   
   @john-bodley @mistercrunch  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services