You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/10 16:49:36 UTC

[GitHub] [skywalking] Superskyyy commented on issue #6018: [Python] Revise plugins involved with http client, avoid recording password in url

Superskyyy commented on issue #6018:
URL: https://github.com/apache/skywalking/issues/6018#issuecomment-896141522


   > Now some of the http client plugins record the `username:password` into the tag `peer` and `url`, this should be removed explicitly.
   > 
   > Example request url might be http://username:password@example.com
   
   Should I remove the auth part entirely from url/peer or replace any `userabc:pwcde` with literal `username:password`? I feel like replacing may be a good choice too (I hope no one uses `password` as their actual password).  @kezhenxu94  @wu-sheng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org