You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/13 14:19:35 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #3310: [Bug]
Use equals() method to judge whether "type" are equal
morningman opened a new pull request #3310: [Bug] Use equals() method to judge whether "type" are equal
URL: https://github.com/apache/incubator-doris/pull/3310
I don't why, but I found that sometimes when I use "==" to judge the equality of type,
it return false, even if the types are exactly same.
ISSUE: #3309
This CL only changes `==` to `equals()` to solve the problem, but the reason is still unknown.
And there are some other place that also use `==` to judge the equality of `Type`, I left them
unchanged until they encounter errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangpinghuang commented on issue #3310: [Bug] Use
equals() method to judge whether "type" are equal
Posted by GitBox <gi...@apache.org>.
kangpinghuang commented on issue #3310: [Bug] Use equals() method to judge whether "type" are equal
URL: https://github.com/apache/incubator-doris/pull/3310#issuecomment-613250009
I think we should add some unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #3310: [Bug] Use
equals() method to judge whether "type" are equal
Posted by GitBox <gi...@apache.org>.
morningman commented on issue #3310: [Bug] Use equals() method to judge whether "type" are equal
URL: https://github.com/apache/incubator-doris/pull/3310#issuecomment-612950274
> > I agree. I am just puzzled why they are not the same object. I think they should be....
>
> Without knowing why, we can still make Doris work in the right way.
> So we can move it to another issue to investigate later on.
OK, I will try to find out all `==` and change them to `equals()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #3310: [Bug] Use
equals() method to judge whether "type" are equal
Posted by GitBox <gi...@apache.org>.
morningman commented on issue #3310: [Bug] Use equals() method to judge whether "type" are equal
URL: https://github.com/apache/incubator-doris/pull/3310#issuecomment-612947145
> @morningman
> I think we should replace all `==` compare with `equals`. `==` returns true only when the two sides refer the same object. I think all the type compare means to test if they are the same type, not the same object.
I agree. I am just puzzled why they are not the same object. I think they should be....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on issue #3310: [Bug] Use equals()
method to judge whether "type" are equal
Posted by GitBox <gi...@apache.org>.
imay commented on issue #3310: [Bug] Use equals() method to judge whether "type" are equal
URL: https://github.com/apache/incubator-doris/pull/3310#issuecomment-612949806
> I agree. I am just puzzled why they are not the same object. I think they should be....
Without knowing why, we can still make Doris work in the right way.
So we can move it to another issue to investigate later on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on issue #3310: [Bug] Use equals()
method to judge whether "type" are equal
Posted by GitBox <gi...@apache.org>.
imay commented on issue #3310: [Bug] Use equals() method to judge whether "type" are equal
URL: https://github.com/apache/incubator-doris/pull/3310#issuecomment-612945803
@morningman
I think we should replace all `==` compare with `equals`. `==` returns true only when the two sides refer the same object. I think all the type compare means to test if they are the same type, not the same object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3310: [Bug] Use
equals() method to judge whether "type" are equal
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3310: [Bug] Use equals() method to judge whether "type" are equal
URL: https://github.com/apache/incubator-doris/pull/3310
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #3310: [Bug] Use
equals() method to judge whether "type" are equal
Posted by GitBox <gi...@apache.org>.
morningman commented on issue #3310: [Bug] Use equals() method to judge whether "type" are equal
URL: https://github.com/apache/incubator-doris/pull/3310#issuecomment-613385117
> I think we should add some unit tests.
OK, I added a case described in #3309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org