You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "jayzhan211 (via GitHub)" <gi...@apache.org> on 2024/08/18 01:20:35 UTC
Re: [PR] Fix: generate_series function support string type [datafusion]
jayzhan211 commented on code in PR #12002:
URL: https://github.com/apache/datafusion/pull/12002#discussion_r1720868582
##########
datafusion/functions-nested/src/range.rs:
##########
@@ -317,6 +315,14 @@ fn gen_range_date(args: &[ArrayRef], include_upper: bool) -> Result<ArrayRef> {
let values_builder = Date32Builder::new();
let mut list_builder = ListBuilder::new(values_builder);
+ if start_array.unwrap().is_null(0)
Review Comment:
Actually this function's signature is quite complex, I think we should use `UserDefined` signature to handle all possible types and **coerce** them to the expected one with `coerce_types`. Then we don't need to handle null inside the actual computation here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org