You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/10/16 21:21:45 UTC

Review Request: Removed copying cpuset.cpus and cpuset.mems from the cgroups isolation module (since this is being done by default now).

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7621/
-----------------------------------------------------------

Review request for mesos, Vinod Kone, Jie Yu, and Ben Mahler.


Description
-------

See summary.


Diffs
-----

  src/slave/cgroups_isolation_module.cpp 0d4ee3246eae4d8bd6f19d59c7221c8b4884db1e 

Diff: https://reviews.apache.org/r/7621/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request: Removed copying cpuset.cpus and cpuset.mems from the cgroups isolation module (since this is being done by default now).

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7621/#review12594
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Oct. 16, 2012, 7:21 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7621/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2012, 7:21 p.m.)
> 
> 
> Review request for mesos, Vinod Kone, Jie Yu, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolation_module.cpp 0d4ee3246eae4d8bd6f19d59c7221c8b4884db1e 
> 
> Diff: https://reviews.apache.org/r/7621/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request: Removed copying cpuset.cpus and cpuset.mems from the cgroups isolation module (since this is being done by default now).

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7621/#review12487
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Oct. 16, 2012, 7:21 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7621/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2012, 7:21 p.m.)
> 
> 
> Review request for mesos, Vinod Kone, Jie Yu, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolation_module.cpp 0d4ee3246eae4d8bd6f19d59c7221c8b4884db1e 
> 
> Diff: https://reviews.apache.org/r/7621/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request: Removed copying cpuset.cpus and cpuset.mems from the cgroups isolation module (since this is being done by default now).

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7621/#review12574
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Oct. 16, 2012, 7:21 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7621/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2012, 7:21 p.m.)
> 
> 
> Review request for mesos, Vinod Kone, Jie Yu, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolation_module.cpp 0d4ee3246eae4d8bd6f19d59c7221c8b4884db1e 
> 
> Diff: https://reviews.apache.org/r/7621/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>