[GitHub] [superset] mihir174 edited a comment on pull request #12554: feat(native-filters): Show alert for unsaved filters after cancelling Filter Config Modal

[GitBox <gi...@apache.org>]

mihir174 edited a comment on pull request #12554:
URL: https://github.com/apache/superset/pull/12554#issuecomment-763418195


   @agatapst @junlincc 
   I think the warning is awesome! Not sure if this is too late but just some design input - it's an uncommon pattern to have the "Confirm" button in addition to the "Save" and "Cancel" buttons. It would be better if we replaced the "Save" and "Cancel" buttons completely with "Yes, cancel" and "Keep editing". 
   
   Also, the bottom bar with those buttons should not be part of the scrolling window - it causes a bit of jumpiness. Here's a visual for the warning replacing the existing buttons - 
   <img width="753" alt="Screen Shot 2021-01-20 at 12 10 12 AM" src="https://user-images.githubusercontent.com/64227069/105145641-df7ba400-5ab3-11eb-9fe8-7d78d35f3826.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org