You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/06/17 15:42:07 UTC
[GitHub] [hadoop] elek commented on issue #978: HDDS-1694.
TestNodeReportHandler is failing with NPE
elek commented on issue #978: HDDS-1694. TestNodeReportHandler is failing with NPE
URL: https://github.com/apache/hadoop/pull/978#issuecomment-502737684
I fixed the constructor of SCMNodeManager to have only the [minimal external dependencies](https://en.wikipedia.org/wiki/Law_of_Demeter) (to make it easier to unit test). For example now it has SCMStorageConfig as constructor parameter instead of StorageContainerManager as the StorageContaienrManager is used only to get SCMStorageConfig. Having the SCMStorageConfig in constructor makes the dependency more visible.
Strictly speaking the NPE can be fixed with half of the patch but as It's a very small patch I think it's acceptable. (But let me know if you prefer to manage the changes in two patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org