[GitHub] [incubator-datasketches-memory] gianm commented on issue #109: Cache arrayBaseOffset.

[GitBox <gi...@apache.org>]

gianm commented on issue #109: Cache arrayBaseOffset.
URL: https://github.com/apache/incubator-datasketches-memory/pull/109#issuecomment-516514366
 
 
   > The ordering of the chained if...then...else. The top of the chain is byte[] which is by far the most likely and in the right spot. However, I would place boolean, short, char, object at the bottom and push up int, long, float, double, which are far more likely.
   
   I reordered the list as suggested, and added a comment about why the ordering was done in this way.
   
   > I didn't see any unit tests with this PR and I suspect that most of the if...then...else chain is never touched with the current tests, but I haven't confirmed that.
   
   I just added some that test each branch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org