[jira] Commented: (HDFS-1152) appendFile does not recheck lease in second synchronized block

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974022#action_12974022 ] 

Hadoop QA commented on HDFS-1152:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12444449/hdfs-1152.txt
  against trunk revision 1051669.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/26//console

This message is automatically generated.

> appendFile does not recheck lease in second synchronized block
> --------------------------------------------------------------
>
>                 Key: HDFS-1152
>                 URL: https://issues.apache.org/jira/browse/HDFS-1152
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.20-append, 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: appendFile-recheck-lease.txt, hdfs-1152.txt
>
>
> FSN.appendFile is made up of two synchronized sections. The second section assumes that the file has not gotten modified during the unsynchronized part in between. We should recheck the lease in the second block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.