You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2016/06/16 04:18:50 UTC
[GitHub] zeppelin pull request #1022: [HOTFIX][DOC] Fix image path again
GitHub user minahlee opened a pull request:
https://github.com/apache/zeppelin/pull/1022
[HOTFIX][DOC] Fix image path again
### What is this PR for?
Realized that #1020 doesn't do the job. This PR does fix the issue of broken image on website and already documented on the website
### What type of PR is it?
Bug Fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/zeppelin hotfix/doc_image2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1022.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1022
----
commit 17309ee209fe51c791e660f37b3418b50544681f
Author: Mina Lee <mi...@apache.org>
Date: 2016-06-16T04:15:45Z
Fix path again
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1022: [HOTFIX][DOC] Fix image path again
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1022
Ok let me merge it then :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1022: [HOTFIX][DOC] Fix image path again
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1022
Yes, we fixed the `/assets` type of links a few times before.
The best way to check the image link it to use the 'sources' tab in the developer tools to see the file tree.
<img width="235" alt="screen shot 2016-06-16 at 1 23 31 pm" src="https://cloud.githubusercontent.com/assets/710411/16105456/988d8618-33c5-11e6-9a2c-1416da42c9b8.png">
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1022: [HOTFIX][DOC] Fix image path again
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1022
@minahlee I think you can merge it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1022: [HOTFIX][DOC] Fix image path again
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1022
@corneadoug FYI you don't need to push it to svn since I already did.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1022: [HOTFIX][DOC] Fix image path again
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1022
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1022: [HOTFIX][DOC] Fix image path again
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1022
@corneadoug yes, the doc for 0.6.0 will be published based on branch-0.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1022: [HOTFIX][DOC] Fix image path again
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1022
@minahlee Should it be merged also in 0.6.0 branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1022: [HOTFIX][DOC] Fix image path again
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1022
Thank you for the tip! wont make same mistake again...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---