You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2019/01/11 06:14:11 UTC
Review Request 69714: Fixed a bug in docker_containerizer_tests.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69714/
-----------------------------------------------------------
Review request for mesos, Deepak Goel, Gilbert Song, and Qian Zhang.
Repository: mesos
Description
-------
Forgot to call MesosTest::SetUp() and MesosTest::TearDown() in the
override methods.
Diffs
-----
src/tests/containerizer/docker_containerizer_tests.cpp 2feead9ace26542821002531a6006fd00f7088b3
Diff: https://reviews.apache.org/r/69714/diff/1/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 69714: Fixed a bug in
docker_containerizer_tests.cpp.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69714/#review211863
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Jan. 10, 2019, 10:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69714/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2019, 10:14 p.m.)
>
>
> Review request for mesos, Deepak Goel, Gilbert Song, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Forgot to call MesosTest::SetUp() and MesosTest::TearDown() in the
> override methods.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 2feead9ace26542821002531a6006fd00f7088b3
>
>
> Diff: https://reviews.apache.org/r/69714/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 69714: Fixed a bug in
docker_containerizer_tests.cpp.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69714/#review211874
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Jan. 11, 2019, 2:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69714/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 2:14 p.m.)
>
>
> Review request for mesos, Deepak Goel, Gilbert Song, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Forgot to call MesosTest::SetUp() and MesosTest::TearDown() in the
> override methods.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 2feead9ace26542821002531a6006fd00f7088b3
>
>
> Diff: https://reviews.apache.org/r/69714/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>