You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Graham Leggett <mi...@sharp.fm> on 1999/10/11 19:27:18 UTC

Patch - mod_proxy/4236: Reverse proxy features disables caching features

Hi all,

I put together a patch that fixes this problem.

The code to merge virtual host and global configuration was missing, and
as a result configuration inside virtual hosts completely overrode the
global configuration with default values.

The effect was that ProxyPass statements inside virtual hosts caused any
globally defined cache directory to be returned to it's default of
disabled.

This patch also fixes another problem with the ProxyReceiveBufferSize
option. It's default value was left unset, and was used uninitialised
which could have caused sporadic problems with the proxy.

The patch is against Apache v1.3.9.

Regards,
Graham
-- 
-----------------------------------------
minfrin@sharp.fm		"There's a moon
					over Bourbon Street
						tonight...

Re: Patch - mod_proxy/4236: Reverse proxy features disables caching features

Posted by Martin Kraemer <Ma...@mch.sni.de>.
On Mon, Oct 11, 1999 at 07:27:18PM +0200, Graham Leggett wrote:
> The code to merge virtual host and global configuration was missing, and
> as a result configuration inside virtual hosts completely overrode the
> global configuration with default values.

Well observed... And I always wondered why... :-O

> This patch also fixes another problem with the ProxyReceiveBufferSize
> option. It's default value was left unset, and was used uninitialised
> which could have caused sporadic problems with the proxy.

Oops! Looks good (untested as yet), even if the *_set variables aren't
required for *every* configuration value. Granted, it's cleaner this way.
Unless anyone objects, I'll go test and commit it.

    Martin
-- 
<Ma...@MchP.Siemens.De>             |    Fujitsu Siemens
Fon: +49-89-636-46021, FAX: +49-89-636-41143 | 81730  Munich,  Germany