You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/08/07 06:57:23 UTC

[GitHub] [hudi] codope commented on a diff in pull request #6254: [HUDI-4508] Repair the exception when reading optimized query for mor in hive and presto/trino

codope commented on code in PR #6254:
URL: https://github.com/apache/hudi/pull/6254#discussion_r939617727


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieCopyOnWriteTableInputFormat.java:
##########
@@ -261,6 +263,20 @@ private List<FileStatus> listStatusForSnapshotMode(JobConf job,
     return targetFiles;
   }
 
+  protected boolean checkIfValidFileSlice(FileSlice fileSlice) {
+    Option<HoodieBaseFile> baseFileOpt = fileSlice.getBaseFile();

Review Comment:
   As per the naming convention, `isValidFileSlice` sounds better. Also, I notice that the override of this method in `HoodieMergeOnReadTableInputFormat` is logically same. So, why do we need to override?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org