You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by ma...@apache.org on 2025/01/14 01:01:14 UTC
(cloudberry) 01/20: Bump minimum requirement of zstd to 1.4.0
This is an automated email from the ASF dual-hosted git repository.
maxyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit c48753031ac492dc21dff4df2c3f62a7a4678841
Author: Marbin Tan <tm...@vmware.com>
AuthorDate: Wed Jun 7 14:42:27 2023 -0700
Bump minimum requirement of zstd to 1.4.0
zstd 1.4.0 introduces stabilization for some of the advanced APIs.
It also has some performance enhancements compared to the older version.
Given that the release has been out since 2019, we should follow suit
with Postgres and upgrade to 1.4.0.
gpdb-dev discussion: https://groups.google.com/a/greenplum.org/g/gpdb-dev/c/0PyQvNB2aNI
Reviewed-by: Soumyadeep Chakraborty <so...@gmail.com>
Reviewed-by: Ashwin Agrawal <aa...@vmware.com>
---
configure | 22 +++++++++++-----------
configure.ac | 4 ++--
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/configure b/configure
index 6a7e4103ee..7ee6e2de51 100755
--- a/configure
+++ b/configure
@@ -10344,19 +10344,19 @@ $as_echo "$with_zstd" >&6; }
if test "$with_zstd" = yes; then
pkg_failed=no
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for libzstd >= 1.1.1" >&5
-$as_echo_n "checking for libzstd >= 1.1.1... " >&6; }
+{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for libzstd >= 1.4.0" >&5
+$as_echo_n "checking for libzstd >= 1.4.0... " >&6; }
if test -n "$ZSTD_CFLAGS"; then
pkg_cv_ZSTD_CFLAGS="$ZSTD_CFLAGS"
elif test -n "$PKG_CONFIG"; then
if test -n "$PKG_CONFIG" && \
- { { $as_echo "$as_me:${as_lineno-$LINENO}: \$PKG_CONFIG --exists --print-errors \"libzstd >= 1.1.1\""; } >&5
- ($PKG_CONFIG --exists --print-errors "libzstd >= 1.1.1") 2>&5
+ { { $as_echo "$as_me:${as_lineno-$LINENO}: \$PKG_CONFIG --exists --print-errors \"libzstd >= 1.4.0\""; } >&5
+ ($PKG_CONFIG --exists --print-errors "libzstd >= 1.4.0") 2>&5
ac_status=$?
$as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
test $ac_status = 0; }; then
- pkg_cv_ZSTD_CFLAGS=`$PKG_CONFIG --cflags "libzstd >= 1.1.1" 2>/dev/null`
+ pkg_cv_ZSTD_CFLAGS=`$PKG_CONFIG --cflags "libzstd >= 1.4.0" 2>/dev/null`
test "x$?" != "x0" && pkg_failed=yes
else
pkg_failed=yes
@@ -10368,12 +10368,12 @@ if test -n "$ZSTD_LIBS"; then
pkg_cv_ZSTD_LIBS="$ZSTD_LIBS"
elif test -n "$PKG_CONFIG"; then
if test -n "$PKG_CONFIG" && \
- { { $as_echo "$as_me:${as_lineno-$LINENO}: \$PKG_CONFIG --exists --print-errors \"libzstd >= 1.1.1\""; } >&5
- ($PKG_CONFIG --exists --print-errors "libzstd >= 1.1.1") 2>&5
+ { { $as_echo "$as_me:${as_lineno-$LINENO}: \$PKG_CONFIG --exists --print-errors \"libzstd >= 1.4.0\""; } >&5
+ ($PKG_CONFIG --exists --print-errors "libzstd >= 1.4.0") 2>&5
ac_status=$?
$as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
test $ac_status = 0; }; then
- pkg_cv_ZSTD_LIBS=`$PKG_CONFIG --libs "libzstd >= 1.1.1" 2>/dev/null`
+ pkg_cv_ZSTD_LIBS=`$PKG_CONFIG --libs "libzstd >= 1.4.0" 2>/dev/null`
test "x$?" != "x0" && pkg_failed=yes
else
pkg_failed=yes
@@ -10394,14 +10394,14 @@ else
_pkg_short_errors_supported=no
fi
if test $_pkg_short_errors_supported = yes; then
- ZSTD_PKG_ERRORS=`$PKG_CONFIG --short-errors --print-errors --cflags --libs "libzstd >= 1.1.1" 2>&1`
+ ZSTD_PKG_ERRORS=`$PKG_CONFIG --short-errors --print-errors --cflags --libs "libzstd >= 1.4.0" 2>&1`
else
- ZSTD_PKG_ERRORS=`$PKG_CONFIG --print-errors --cflags --libs "libzstd >= 1.1.1" 2>&1`
+ ZSTD_PKG_ERRORS=`$PKG_CONFIG --print-errors --cflags --libs "libzstd >= 1.4.0" 2>&1`
fi
# Put the nasty error message in config.log where it belongs
echo "$ZSTD_PKG_ERRORS" >&5
- as_fn_error $? "Package requirements (libzstd >= 1.1.1) were not met:
+ as_fn_error $? "Package requirements (libzstd >= 1.4.0) were not met:
$ZSTD_PKG_ERRORS
diff --git a/configure.ac b/configure.ac
index aee14b35da..f5ad58194c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1264,8 +1264,8 @@ AC_MSG_RESULT([$with_zstd])
AC_SUBST(with_zstd)
if test "$with_zstd" = yes; then
- dnl zstd_errors.h was renamed from error_public.h in v1.1.1
- PKG_CHECK_MODULES([ZSTD], [libzstd >= 1.1.1])
+ dnl zstd_errors.h was renamed from error_public.h in v1.4.0
+ PKG_CHECK_MODULES([ZSTD], [libzstd >= 1.4.0])
fi
#
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org