You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/05/03 16:45:46 UTC
Re: Review Request 58847: Checkpointed and recovered
ContainerLaunchInfo for non-orphans.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58847/
-----------------------------------------------------------
(Updated May 3, 2017, 4:45 p.m.)
Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone.
Changes
-------
Addressed comments.
Repository: mesos
Description
-------
In mesos containerizer, cache each container's launch info and
recover it for non-orphan containers. This is a prerequisite for
persisting some container characteristics across agent failover.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
src/slave/containerizer/mesos/paths.hpp d85fd34660faacd9c73de2ba7b87b3bbd4b6007b
src/slave/containerizer/mesos/paths.cpp ed4bbd2491e71ad1e4a41e0575b514377d02da9b
Diff: https://reviews.apache.org/r/58847/diff/2/
Changes: https://reviews.apache.org/r/58847/diff/1-2/
Testing
-------
See https://reviews.apache.org/r/58718/
Thanks,
Alexander Rukletsov
Re: Review Request 58847: Checkpointed and recovered
ContainerLaunchInfo for non-orphans.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58847/#review174229
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On May 3, 2017, 4:45 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58847/
> -----------------------------------------------------------
>
> (Updated May 3, 2017, 4:45 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In mesos containerizer, cache each container's launch info and
> recover it for non-orphan containers. This is a prerequisite for
> persisting some container characteristics across agent failover.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
> src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
> src/slave/containerizer/mesos/paths.hpp d85fd34660faacd9c73de2ba7b87b3bbd4b6007b
> src/slave/containerizer/mesos/paths.cpp ed4bbd2491e71ad1e4a41e0575b514377d02da9b
>
>
> Diff: https://reviews.apache.org/r/58847/diff/2/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/58718/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58847: Checkpointed and recovered
ContainerLaunchInfo for non-orphans.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58847/
-----------------------------------------------------------
(Updated May 9, 2017, 2:31 p.m.)
Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone.
Changes
-------
Rebased. NNTR.
Repository: mesos
Description
-------
In mesos containerizer, cache each container's launch info and
recover it for non-orphan containers. This is a prerequisite for
persisting some container characteristics across agent failover.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
src/slave/containerizer/mesos/containerizer.cpp 3d724945812c0359ed175ce232f70886dc4401c8
src/slave/containerizer/mesos/paths.hpp d85fd34660faacd9c73de2ba7b87b3bbd4b6007b
src/slave/containerizer/mesos/paths.cpp ed4bbd2491e71ad1e4a41e0575b514377d02da9b
Diff: https://reviews.apache.org/r/58847/diff/3/
Changes: https://reviews.apache.org/r/58847/diff/2-3/
Testing
-------
See https://reviews.apache.org/r/58718/
Thanks,
Alexander Rukletsov