You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hugo Trippaers <ht...@schubergphilis.com> on 2012/07/02 12:20:33 UTC
Re: Review Request: Make xen.check.hvm a proper parameter
> On June 29, 2012, 10:28 p.m., disheng su wrote:
> > xen.check.hvm should be put into component.xml.in, like what we did for configurationdao
> > <dao name="Configuration configuration server" class="com.cloud.configuration.dao.ConfigurationDaoImpl">
> > <param name="premium">true</param>
> > </dao>
> >
Should we make it a hidden parameter?
If i understand the code correctly anything specified in the components.xml param section overrides the default in Config.java
- Hugo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5655/#review8767
-----------------------------------------------------------
On June 29, 2012, 6:52 a.m., Hugo Trippaers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5655/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 6:52 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Make xen.check.hvm a proper parameter in config.java and set the default to false
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java 4fd202b
> server/src/com/cloud/configuration/Config.java 8936544
>
> Diff: https://reviews.apache.org/r/5655/diff/
>
>
> Testing
> -------
>
> Simple build
> clean-all build-all
>
>
> Thanks,
>
> Hugo Trippaers
>
>