[GitHub] [pinot] robertzych commented on a diff in pull request #10463: Segment compaction for upsert real-time tables

["robertzych (via GitHub)" <gi...@apache.org>]

robertzych commented on code in PR #10463:
URL: https://github.com/apache/pinot/pull/10463#discussion_r1214574091


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/SegmentUtils.java:
##########
@@ -39,14 +39,30 @@ private SegmentUtils() {
   @Nullable
   public static Integer getRealtimeSegmentPartitionId(String segmentName, String realtimeTableName,
       HelixManager helixManager, @Nullable String partitionColumn) {
+    return getRealtimeSegmentPartitionId(
+        segmentName, realtimeTableName, helixManager, partitionColumn, null);
+  }
+
+  @Nullable
+  public static Integer getRealtimeSegmentPartitionId(String segmentName, String realtimeTableName,
+      SegmentZKMetadata segmentZKMetadata) {
+    return getRealtimeSegmentPartitionId(segmentName, realtimeTableName, null, null, segmentZKMetadata);

Review Comment:
   Since the generator is no longer using this, I've rolled it back.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org