You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "gianm (via GitHub)" <gi...@apache.org> on 2024/01/14 09:00:59 UTC
[PR] Lazy, memoized key set in ObjectFlatteners. (druid)
gianm opened a new pull request, #15680:
URL: https://github.com/apache/druid/pull/15680
Useful for two reasons. First, we don't need to recompute the key set on every call to `keySet()`, `size()`, etc. Second, because when dimension discovery is *not* enabled, the parser requests the key set but does not call any methods on it. When the key set is lazy, we can avoid computing it entirely.
Benchmarks:
```
Benchmark Mode Cnt Score Error Units
JsonLineReaderBenchmark.baseline avgt 5 2055.294 ± 28.688 us/op [before]
JsonLineReaderBenchmark.baseline avgt 25 1755.839 ± 4.062 us/op [after]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Lazy, memoized key set in ObjectFlatteners. (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm closed pull request #15680: Lazy, memoized key set in ObjectFlatteners.
URL: https://github.com/apache/druid/pull/15680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Lazy, memoized key set in ObjectFlatteners. (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on PR #15680:
URL: https://github.com/apache/druid/pull/15680#issuecomment-1894606944
Going to mark this a draft while exploring `ObjectFlattener` more eager, which would solve the problem a different way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org