You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/07/29 20:18:27 UTC

[GitHub] [orc] dongjoon-hyun opened a new pull request #788: ORC-882: Remove hamcrest-core test dependency

dongjoon-hyun opened a new pull request #788:
URL: https://github.com/apache/orc/pull/788


   ### What changes were proposed in this pull request?
   
   This PR aims to remove `hamcrest-core` test dependency.
   
   ### Why are the changes needed?
   
   This was added at ORC-60 and is not used now.
   ```
   $ git show 08b854425 | grep hamcrest
   +      <groupId>org.hamcrest</groupId>
   +      <artifactId>hamcrest-core</artifactId>
   +        <groupId>org.hamcrest</groupId>
   +        <artifactId>hamcrest-core</artifactId>
   ```
   
   ### How was this patch tested?
   
   Pass the CIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #788: ORC-882: Remove hamcrest-core test dependency

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #788:
URL: https://github.com/apache/orc/pull/788#issuecomment-889962567


   Thank you so much, @williamhyun .
   Merged to main/1.7.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #788: ORC-882: Remove hamcrest-core test dependency

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #788:
URL: https://github.com/apache/orc/pull/788


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #788: ORC-882: Remove hamcrest-core test dependency

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #788:
URL: https://github.com/apache/orc/pull/788#issuecomment-890438658


   Oh, very sorry, @williamhyun . During more testing, it seems that I only removed the direct dependency. Let me reconsider this. In the worst case, I'll inform here and revert my commit. Sorry for making you confused.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #788: ORC-882: Remove hamcrest-core test dependency

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #788:
URL: https://github.com/apache/orc/pull/788#issuecomment-889479088


   cc @pgaref and @williamhyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org