You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:56:46 UTC

[GitHub] [flink] leonardBang opened a new pull request #13875: [hot-fix][table-runtime] disable unstable tests which use updatebefore time as changelog time in TemporalJoinITCas

leonardBang opened a new pull request #13875:
URL: https://github.com/apache/flink/pull/13875


   ## What is the purpose of the change
   
   * The tests using update before time as changelog time which is unstable. The Event time semantic of update_before message and Delete message is the time in record, when we use previous record time(e.g. insert record's time), this event are dirty data which may lead the tests unstable.
   
   
   ## Brief change log
   
     - update file TemporalJoinITCase
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): ( no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on pull request #13875: [hot-fix][table-runtime] disable unstable tests which use updatebefore time as changelog time in TemporalJoinITCas

Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13875:
URL: https://github.com/apache/flink/pull/13875#issuecomment-720337234


   I will merge it now as the tests are rather unstable and may blocks other PRs. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13875: [hot-fix][table-runtime] disable unstable tests which use updatebefore time as changelog time in TemporalJoinITCas

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13875:
URL: https://github.com/apache/flink/pull/13875#issuecomment-720303648






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong merged pull request #13875: [hot-fix][table-runtime] disable unstable tests which use updatebefore time as changelog time in TemporalJoinITCas

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #13875:
URL: https://github.com/apache/flink/pull/13875


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13875: [hot-fix][table-runtime] disable unstable tests which use updatebefore time as changelog time in TemporalJoinITCas

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13875:
URL: https://github.com/apache/flink/pull/13875#issuecomment-720325931


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d8214afa092603069891d0d038350ffa4ec9c39e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8766",
       "triggerID" : "d8214afa092603069891d0d038350ffa4ec9c39e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d8214afa092603069891d0d038350ffa4ec9c39e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8766) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org