You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/03/23 15:27:57 UTC

[GitHub] [nifi] ottobackwards commented on a change in pull request #4923: NIFI-8354 ExecuteStreamCommand processor doesn't delete the temp file…

ottobackwards commented on a change in pull request #4923:
URL: https://github.com/apache/nifi/pull/4923#discussion_r599677321



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java
##########
@@ -471,6 +471,7 @@ public void onTrigger(ProcessContext context, final ProcessSession session) thro
         try {
             process = builder.start();
         } catch (IOException e) {

Review comment:
       `delete()` can throw several exceptions here, I think they should be handled.
   maybe     https://github.com/apache/nifi/blob/f9ae3bb9c970cd8d6d1d9e10f07cab9bdb66baa9/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/util/FileUtils.java#L77 ,  and the component logger passed so failures can be logged.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org