You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Abhishek Singh Chouhan (Jira)" <ji...@apache.org> on 2020/02/10 22:17:00 UTC
[jira] [Comment Edited] (HBASE-23825) Increment proto conversion is
broken
[ https://issues.apache.org/jira/browse/HBASE-23825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033988#comment-17033988 ]
Abhishek Singh Chouhan edited comment on HBASE-23825 at 2/10/20 10:16 PM:
--------------------------------------------------------------------------
This is not a problem in master and 2.x since we reverted HBASE-18026 from those branches. FYI [~andrew.purtell@gmail.com]
was (Author: abhishek.chouhan):
This is not a problem in master and 2.x since we reverted HBASE-18026. FYI [~andrew.purtell@gmail.com]
> Increment proto conversion is broken
> ------------------------------------
>
> Key: HBASE-23825
> URL: https://issues.apache.org/jira/browse/HBASE-23825
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.5.0, 1.3.6, 1.4.12
> Reporter: Abhishek Singh Chouhan
> Assignee: Abhishek Singh Chouhan
> Priority: Major
>
> While converting the request back to Increment using ProtobufUtil.toIncrement we incorrectly use the optimization to avoid copying the byte array(HBaseZeroCopyByteString#zeroCopyGetBytes) on a BoundedByteString. The optimization was only meant for LiteralByteString where it is safe to use the backing byte array, however it ends up being used to BoundedByteString which is a subclass of LiteralByteString. This essentially breaks increments since we end up creating wrong cells on the server side.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)