[GitHub] [ambari] hapylestat commented on a change in pull request #3195: OneFS mpack fix for performance (new version 1.0.3)

[GitBox <gi...@apache.org>]

hapylestat commented on a change in pull request #3195:
URL: https://github.com/apache/ambari/pull/3195#discussion_r428537513



##########
File path: contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/service_advisor.py
##########
@@ -116,9 +116,15 @@ def getServiceConfigurationRecommendations(self, configs, clusterData, services,
         putHdfsSiteProperty("dfs.namenode.http-address", Uri.http_namenode(services).fix_host(onefs_host))
         putHdfsSiteProperty("dfs.namenode.https-address", Uri.https_namenode(services).fix_host(onefs_host))
         # self.updateYarnConfig(configs, services) TODO doesn't work possibly due to a UI bug (Couldn't retrieve 'capacity-scheduler' from services)
+        self.updateHbaseConfig(configs, services)
       except KeyError as e:
         self.logger.info('Cannot get OneFS properties from config. KeyError: %s' % e)
 
+    def updateHbaseConfig(self, configs, services):
+      if not 'HBASE' in self.installedServices(services): return

Review comment:
       no one-liners allowed, it is pain to read 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org