You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by li...@apache.org on 2008/02/20 23:12:48 UTC
svn commit: r629634 - in /incubator/shindig/trunk/features:
analytics/feature.xml caja/feature.xml flash/feature.xml ifpc/feature.xml
minimessage/feature.xml opensocial-reference/feature.xml rpc/feature.xml
skins/feature.xml tabs/feature.xml
Author: lindner
Date: Wed Feb 20 14:12:44 2008
New Revision: 629634
URL: http://svn.apache.org/viewvc?rev=629634&view=rev
Log:
Should fix SHINDIG-43, at least it seems to do the right thing for me..
Modified:
incubator/shindig/trunk/features/analytics/feature.xml
incubator/shindig/trunk/features/caja/feature.xml
incubator/shindig/trunk/features/flash/feature.xml
incubator/shindig/trunk/features/ifpc/feature.xml
incubator/shindig/trunk/features/minimessage/feature.xml
incubator/shindig/trunk/features/opensocial-reference/feature.xml
incubator/shindig/trunk/features/rpc/feature.xml
incubator/shindig/trunk/features/skins/feature.xml
incubator/shindig/trunk/features/tabs/feature.xml
Modified: incubator/shindig/trunk/features/analytics/feature.xml
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/features/analytics/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
==============================================================================
--- incubator/shindig/trunk/features/analytics/feature.xml (original)
+++ incubator/shindig/trunk/features/analytics/feature.xml Wed Feb 20 14:12:44 2008
@@ -18,6 +18,7 @@
-->
<feature>
<name>analytics</name>
+ <dependency>core</dependency>
<gadget>
<script src="http://www.google.com/ig/lib/liburchin.js"/>
<script src="http://www.google.com/ig/lib/libanalytics.js"/>
Modified: incubator/shindig/trunk/features/caja/feature.xml
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/features/caja/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
==============================================================================
--- incubator/shindig/trunk/features/caja/feature.xml (original)
+++ incubator/shindig/trunk/features/caja/feature.xml Wed Feb 20 14:12:44 2008
@@ -21,6 +21,7 @@
-->
<feature>
<name>caja</name>
+ <dependency>core</dependency>
<gadget>
<script src="caja.js"></script>
<script src="html-sanitizer.js"></script>
Modified: incubator/shindig/trunk/features/flash/feature.xml
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/features/flash/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
==============================================================================
--- incubator/shindig/trunk/features/flash/feature.xml (original)
+++ incubator/shindig/trunk/features/flash/feature.xml Wed Feb 20 14:12:44 2008
@@ -18,6 +18,7 @@
-->
<feature>
<name>flash</name>
+ <dependency>core</dependency>
<gadget>
<script src="flash.js"/>
</gadget>
Modified: incubator/shindig/trunk/features/ifpc/feature.xml
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/features/ifpc/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
==============================================================================
--- incubator/shindig/trunk/features/ifpc/feature.xml (original)
+++ incubator/shindig/trunk/features/ifpc/feature.xml Wed Feb 20 14:12:44 2008
@@ -18,6 +18,7 @@
-->
<feature>
<name>ifpc</name>
+ <dependency>core</dependency>
<gadget>
<script src="ifpc.js"/>
</gadget>
Modified: incubator/shindig/trunk/features/minimessage/feature.xml
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/features/minimessage/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
==============================================================================
--- incubator/shindig/trunk/features/minimessage/feature.xml (original)
+++ incubator/shindig/trunk/features/minimessage/feature.xml Wed Feb 20 14:12:44 2008
@@ -18,6 +18,7 @@
-->
<feature>
<name>minimessage</name>
+ <dependency>core</dependency>
<gadget>
<script src="minimessage.js"/>
</gadget>
Modified: incubator/shindig/trunk/features/opensocial-reference/feature.xml
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/features/opensocial-reference/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
==============================================================================
--- incubator/shindig/trunk/features/opensocial-reference/feature.xml (original)
+++ incubator/shindig/trunk/features/opensocial-reference/feature.xml Wed Feb 20 14:12:44 2008
@@ -20,7 +20,7 @@
<feature>
<name>opensocial-reference</name>
<!-- all known opensocial implementations assume that ifpc is present. -->
- <dependency>ifpc</dependency>
+ <dependency>rpc</dependency>
<gadget>
<script src="opensocial.js"/>
<script src="activity.js"/>
Modified: incubator/shindig/trunk/features/rpc/feature.xml
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/features/rpc/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
==============================================================================
--- incubator/shindig/trunk/features/rpc/feature.xml (original)
+++ incubator/shindig/trunk/features/rpc/feature.xml Wed Feb 20 14:12:44 2008
@@ -28,6 +28,7 @@
(if true, all calls to rpc.call will use the same wire format as ifpc).
-->
<name>rpc</name>
+ <dependency>core</dependency>
<gadget>
<script src="rpc.js"/>
</gadget>
Modified: incubator/shindig/trunk/features/skins/feature.xml
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/features/skins/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
==============================================================================
--- incubator/shindig/trunk/features/skins/feature.xml (original)
+++ incubator/shindig/trunk/features/skins/feature.xml Wed Feb 20 14:12:44 2008
@@ -18,6 +18,7 @@
-->
<feature>
<name>skins</name>
+ <dependency>core</dependency>
<gadget>
<script src="skins.js"/>
</gadget>
Modified: incubator/shindig/trunk/features/tabs/feature.xml
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/features/tabs/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
==============================================================================
--- incubator/shindig/trunk/features/tabs/feature.xml (original)
+++ incubator/shindig/trunk/features/tabs/feature.xml Wed Feb 20 14:12:44 2008
@@ -18,6 +18,7 @@
-->
<feature>
<name>tabs</name>
+ <dependency>core</dependency>
<gadget>
<script src="tabs.js"/>
</gadget>
Re: svn commit: r629634 - in /incubator/shindig/trunk/features: analytics/feature.xml caja/feature.xml flash/feature.xml ifpc/feature.xml minimessage/feature.xml opensocial-reference/feature.xml rpc/feature.xml skins/feature.xml tabs/feature.xml
Posted by Kevin Brown <et...@google.com>.
This is not the right thing to do -- can you please revert this change? This
breaks the feature dependency graph. Core is an implicit feature. This just
masks the real problem.
On Wed, Feb 20, 2008 at 2:12 PM, <li...@apache.org> wrote:
> Author: lindner
> Date: Wed Feb 20 14:12:44 2008
> New Revision: 629634
>
> URL: http://svn.apache.org/viewvc?rev=629634&view=rev
> Log:
> Should fix SHINDIG-43, at least it seems to do the right thing for me..
>
> Modified:
> incubator/shindig/trunk/features/analytics/feature.xml
> incubator/shindig/trunk/features/caja/feature.xml
> incubator/shindig/trunk/features/flash/feature.xml
> incubator/shindig/trunk/features/ifpc/feature.xml
> incubator/shindig/trunk/features/minimessage/feature.xml
> incubator/shindig/trunk/features/opensocial-reference/feature.xml
> incubator/shindig/trunk/features/rpc/feature.xml
> incubator/shindig/trunk/features/skins/feature.xml
> incubator/shindig/trunk/features/tabs/feature.xml
>
> Modified: incubator/shindig/trunk/features/analytics/feature.xml
> URL:
> http://svn.apache.org/viewvc/incubator/shindig/trunk/features/analytics/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
>
> ==============================================================================
> --- incubator/shindig/trunk/features/analytics/feature.xml (original)
> +++ incubator/shindig/trunk/features/analytics/feature.xml Wed Feb 20
> 14:12:44 2008
> @@ -18,6 +18,7 @@
> -->
> <feature>
> <name>analytics</name>
> + <dependency>core</dependency>
> <gadget>
> <script src="http://www.google.com/ig/lib/liburchin.js"/>
> <script src="http://www.google.com/ig/lib/libanalytics.js"/>
>
> Modified: incubator/shindig/trunk/features/caja/feature.xml
> URL:
> http://svn.apache.org/viewvc/incubator/shindig/trunk/features/caja/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
>
> ==============================================================================
> --- incubator/shindig/trunk/features/caja/feature.xml (original)
> +++ incubator/shindig/trunk/features/caja/feature.xml Wed Feb 20 14:12:44
> 2008
> @@ -21,6 +21,7 @@
> -->
> <feature>
> <name>caja</name>
> + <dependency>core</dependency>
> <gadget>
> <script src="caja.js"></script>
> <script src="html-sanitizer.js"></script>
>
> Modified: incubator/shindig/trunk/features/flash/feature.xml
> URL:
> http://svn.apache.org/viewvc/incubator/shindig/trunk/features/flash/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
>
> ==============================================================================
> --- incubator/shindig/trunk/features/flash/feature.xml (original)
> +++ incubator/shindig/trunk/features/flash/feature.xml Wed Feb 20 14:12:44
> 2008
> @@ -18,6 +18,7 @@
> -->
> <feature>
> <name>flash</name>
> + <dependency>core</dependency>
> <gadget>
> <script src="flash.js"/>
> </gadget>
>
> Modified: incubator/shindig/trunk/features/ifpc/feature.xml
> URL:
> http://svn.apache.org/viewvc/incubator/shindig/trunk/features/ifpc/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
>
> ==============================================================================
> --- incubator/shindig/trunk/features/ifpc/feature.xml (original)
> +++ incubator/shindig/trunk/features/ifpc/feature.xml Wed Feb 20 14:12:44
> 2008
> @@ -18,6 +18,7 @@
> -->
> <feature>
> <name>ifpc</name>
> + <dependency>core</dependency>
> <gadget>
> <script src="ifpc.js"/>
> </gadget>
>
> Modified: incubator/shindig/trunk/features/minimessage/feature.xml
> URL:
> http://svn.apache.org/viewvc/incubator/shindig/trunk/features/minimessage/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
>
> ==============================================================================
> --- incubator/shindig/trunk/features/minimessage/feature.xml (original)
> +++ incubator/shindig/trunk/features/minimessage/feature.xml Wed Feb 20
> 14:12:44 2008
> @@ -18,6 +18,7 @@
> -->
> <feature>
> <name>minimessage</name>
> + <dependency>core</dependency>
> <gadget>
> <script src="minimessage.js"/>
> </gadget>
>
> Modified:
> incubator/shindig/trunk/features/opensocial-reference/feature.xml
> URL:
> http://svn.apache.org/viewvc/incubator/shindig/trunk/features/opensocial-reference/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
>
> ==============================================================================
> --- incubator/shindig/trunk/features/opensocial-reference/feature.xml
> (original)
> +++ incubator/shindig/trunk/features/opensocial-reference/feature.xml Wed
> Feb 20 14:12:44 2008
> @@ -20,7 +20,7 @@
> <feature>
> <name>opensocial-reference</name>
> <!-- all known opensocial implementations assume that ifpc is
> present. -->
> - <dependency>ifpc</dependency>
> + <dependency>rpc</dependency>
> <gadget>
> <script src="opensocial.js"/>
> <script src="activity.js"/>
>
> Modified: incubator/shindig/trunk/features/rpc/feature.xml
> URL:
> http://svn.apache.org/viewvc/incubator/shindig/trunk/features/rpc/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
>
> ==============================================================================
> --- incubator/shindig/trunk/features/rpc/feature.xml (original)
> +++ incubator/shindig/trunk/features/rpc/feature.xml Wed Feb 20 14:12:44
> 2008
> @@ -28,6 +28,7 @@
> (if true, all calls to rpc.call will use the same wire format as ifpc).
> -->
> <name>rpc</name>
> + <dependency>core</dependency>
> <gadget>
> <script src="rpc.js"/>
> </gadget>
>
> Modified: incubator/shindig/trunk/features/skins/feature.xml
> URL:
> http://svn.apache.org/viewvc/incubator/shindig/trunk/features/skins/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
>
> ==============================================================================
> --- incubator/shindig/trunk/features/skins/feature.xml (original)
> +++ incubator/shindig/trunk/features/skins/feature.xml Wed Feb 20 14:12:44
> 2008
> @@ -18,6 +18,7 @@
> -->
> <feature>
> <name>skins</name>
> + <dependency>core</dependency>
> <gadget>
> <script src="skins.js"/>
> </gadget>
>
> Modified: incubator/shindig/trunk/features/tabs/feature.xml
> URL:
> http://svn.apache.org/viewvc/incubator/shindig/trunk/features/tabs/feature.xml?rev=629634&r1=629633&r2=629634&view=diff
>
> ==============================================================================
> --- incubator/shindig/trunk/features/tabs/feature.xml (original)
> +++ incubator/shindig/trunk/features/tabs/feature.xml Wed Feb 20 14:12:44
> 2008
> @@ -18,6 +18,7 @@
> -->
> <feature>
> <name>tabs</name>
> + <dependency>core</dependency>
> <gadget>
> <script src="tabs.js"/>
> </gadget>
>
>
>
--
~Kevin
If you received this email by mistake, please delete it, cancel your mail
account, destroy your hard drive, silence any witnesses, and burn down the
building that you're in.