You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Fatima Khan <fa...@gmail.com> on 2018/04/03 12:51:01 UTC
Review Request 66304: RANGER-2041 : Handle validations for passwords
of admin accounts during ranger install.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66304/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
Bugs: RANGER-2041
https://issues.apache.org/jira/browse/RANGER-2041
Repository: ranger
Description
-------
Currently, when Ranger is installed admin,keyadmin, rangerusersync, rangertagsync users are seeded users and they are configurable during the install process. This task is to provide a facility to add validations to the admin users password during ranger install.
Diffs
-----
security-admin/scripts/dba_script.py d5eaaf0
security-admin/scripts/install.properties 8128678
security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java e7a4035
Diff: https://reviews.apache.org/r/66304/diff/1/
Testing
-------
Tested the validation for all password combinations.
Thanks,
Fatima Khan
Re: Review Request 66304: RANGER-2041 : Handle validations for
passwords of admin accounts during ranger install.
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66304/#review200711
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On April 7, 2018, 12:27 p.m., Fatima Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66304/
> -----------------------------------------------------------
>
> (Updated April 7, 2018, 12:27 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
>
>
> Bugs: RANGER-2041
> https://issues.apache.org/jira/browse/RANGER-2041
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, when Ranger is installed admin,keyadmin, rangerusersync, rangertagsync users are seeded users and they are configurable during the install process. This task is to provide a facility to add validations to the admin users password during ranger install.Python doesn’t support ‘ " \ ` so these characters will not be supported during update of default password of seeded users in manual install.
>
>
> Diffs
> -----
>
> security-admin/scripts/changepasswordutil.py 95bd613
> security-admin/scripts/db_setup.py 83ccc32
> security-admin/scripts/dba_script.py d5eaaf0
> security-admin/scripts/install.properties 8128678
> security-admin/scripts/setup.sh f79a79e
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java e7a4035
>
>
> Diff: https://reviews.apache.org/r/66304/diff/2/
>
>
> Testing
> -------
>
> Tested the validation for all password combinations.
>
>
> Thanks,
>
> Fatima Khan
>
>
Re: Review Request 66304: RANGER-2041 : Handle validations for
passwords of admin accounts during ranger install.
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66304/#review200721
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On April 7, 2018, 12:27 p.m., Fatima Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66304/
> -----------------------------------------------------------
>
> (Updated April 7, 2018, 12:27 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
>
>
> Bugs: RANGER-2041
> https://issues.apache.org/jira/browse/RANGER-2041
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, when Ranger is installed admin,keyadmin, rangerusersync, rangertagsync users are seeded users and they are configurable during the install process. This task is to provide a facility to add validations to the admin users password during ranger install.Python doesn’t support ‘ " \ ` so these characters will not be supported during update of default password of seeded users in manual install.
>
>
> Diffs
> -----
>
> security-admin/scripts/changepasswordutil.py 95bd613
> security-admin/scripts/db_setup.py 83ccc32
> security-admin/scripts/dba_script.py d5eaaf0
> security-admin/scripts/install.properties 8128678
> security-admin/scripts/setup.sh f79a79e
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java e7a4035
>
>
> Diff: https://reviews.apache.org/r/66304/diff/2/
>
>
> Testing
> -------
>
> Tested the validation for all password combinations.
>
>
> Thanks,
>
> Fatima Khan
>
>
Re: Review Request 66304: RANGER-2041 : Handle validations for
passwords of admin accounts during ranger install.
Posted by Fatima Khan <fa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66304/
-----------------------------------------------------------
(Updated April 7, 2018, 12:27 p.m.)
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
Bugs: RANGER-2041
https://issues.apache.org/jira/browse/RANGER-2041
Repository: ranger
Description
-------
Currently, when Ranger is installed admin,keyadmin, rangerusersync, rangertagsync users are seeded users and they are configurable during the install process. This task is to provide a facility to add validations to the admin users password during ranger install.Python doesn’t support ‘ " \ ` so these characters will not be supported during update of default password of seeded users in manual install.
Diffs (updated)
-----
security-admin/scripts/changepasswordutil.py 95bd613
security-admin/scripts/db_setup.py 83ccc32
security-admin/scripts/dba_script.py d5eaaf0
security-admin/scripts/install.properties 8128678
security-admin/scripts/setup.sh f79a79e
security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java e7a4035
Diff: https://reviews.apache.org/r/66304/diff/2/
Changes: https://reviews.apache.org/r/66304/diff/1-2/
Testing
-------
Tested the validation for all password combinations.
Thanks,
Fatima Khan
Re: Review Request 66304: RANGER-2041 : Handle validations for
passwords of admin accounts during ranger install.
Posted by Fatima Khan <fa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66304/
-----------------------------------------------------------
(Updated April 4, 2018, 6:43 a.m.)
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
Bugs: RANGER-2041
https://issues.apache.org/jira/browse/RANGER-2041
Repository: ranger
Description (updated)
-------
Currently, when Ranger is installed admin,keyadmin, rangerusersync, rangertagsync users are seeded users and they are configurable during the install process. This task is to provide a facility to add validations to the admin users password during ranger install.Python doesn’t support ‘ " \ ` so these characters will not be supported during update of default password of seeded users in manual install.
Diffs
-----
security-admin/scripts/dba_script.py d5eaaf0
security-admin/scripts/install.properties 8128678
security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java e7a4035
Diff: https://reviews.apache.org/r/66304/diff/1/
Testing
-------
Tested the validation for all password combinations.
Thanks,
Fatima Khan
Re: Review Request 66304: RANGER-2041 : Handle validations for
passwords of admin accounts during ranger install.
Posted by Fatima Khan <fa...@gmail.com>.
> On April 4, 2018, 5:36 a.m., Qiang Zhang wrote:
> > security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java
> > Lines 149-151 (patched)
> > <https://reviews.apache.org/r/66304/diff/1/?file=1989008#file1989008line149>
> >
> > The code does not check the length of the newPassword variable.
The regular expression has the validation in which the length of passsword should be minimum 8 characters.
- Fatima
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66304/#review200422
-----------------------------------------------------------
On April 4, 2018, 6:43 a.m., Fatima Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66304/
> -----------------------------------------------------------
>
> (Updated April 4, 2018, 6:43 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
>
>
> Bugs: RANGER-2041
> https://issues.apache.org/jira/browse/RANGER-2041
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, when Ranger is installed admin,keyadmin, rangerusersync, rangertagsync users are seeded users and they are configurable during the install process. This task is to provide a facility to add validations to the admin users password during ranger install.Python doesn’t support ‘ " \ ` so these characters will not be supported during update of default password of seeded users in manual install.
>
>
> Diffs
> -----
>
> security-admin/scripts/dba_script.py d5eaaf0
> security-admin/scripts/install.properties 8128678
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java e7a4035
>
>
> Diff: https://reviews.apache.org/r/66304/diff/1/
>
>
> Testing
> -------
>
> Tested the validation for all password combinations.
>
>
> Thanks,
>
> Fatima Khan
>
>
Re: Review Request 66304: RANGER-2041 : Handle validations for
passwords of admin accounts during ranger install.
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66304/#review200422
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java
Lines 149-151 (patched)
<https://reviews.apache.org/r/66304/#comment281186>
The code does not check the length of the newPassword variable.
- Qiang Zhang
On April 3, 2018, 12:51 p.m., Fatima Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66304/
> -----------------------------------------------------------
>
> (Updated April 3, 2018, 12:51 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
>
>
> Bugs: RANGER-2041
> https://issues.apache.org/jira/browse/RANGER-2041
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, when Ranger is installed admin,keyadmin, rangerusersync, rangertagsync users are seeded users and they are configurable during the install process. This task is to provide a facility to add validations to the admin users password during ranger install.
>
>
> Diffs
> -----
>
> security-admin/scripts/dba_script.py d5eaaf0
> security-admin/scripts/install.properties 8128678
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java e7a4035
>
>
> Diff: https://reviews.apache.org/r/66304/diff/1/
>
>
> Testing
> -------
>
> Tested the validation for all password combinations.
>
>
> Thanks,
>
> Fatima Khan
>
>
Re: Review Request 66304: RANGER-2041 : Handle validations for
passwords of admin accounts during ranger install.
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66304/#review200369
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On April 3, 2018, 12:51 p.m., Fatima Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66304/
> -----------------------------------------------------------
>
> (Updated April 3, 2018, 12:51 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
>
>
> Bugs: RANGER-2041
> https://issues.apache.org/jira/browse/RANGER-2041
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, when Ranger is installed admin,keyadmin, rangerusersync, rangertagsync users are seeded users and they are configurable during the install process. This task is to provide a facility to add validations to the admin users password during ranger install.
>
>
> Diffs
> -----
>
> security-admin/scripts/dba_script.py d5eaaf0
> security-admin/scripts/install.properties 8128678
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java e7a4035
>
>
> Diff: https://reviews.apache.org/r/66304/diff/1/
>
>
> Testing
> -------
>
> Tested the validation for all password combinations.
>
>
> Thanks,
>
> Fatima Khan
>
>