You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@iotdb.apache.org by Benedict Jin <as...@apache.org> on 2020/12/28 07:43:42 UTC

Propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance

Hello everyone,

As the Apache IoTDB project continues to grow, the maintenance costs that follow have gradually increased. In order to alleviate this problem, I propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance. The following is a list of some robots that I am familiar with, including the official website of the plugin, some brief introductions, and case addresses. I hope it can trigger more great ideas. Welcome to discuss and propose more useful robots.

- [Mergify](https://github.com/marketplace/mergify)
- Mergify is a pull requests automation service. It allows you to trigger actions when your pull requests match defined criteria.
- Example: https://github.com/crate/crate/pull/10881

- [Dependabot](https://github.com/marketplace/dependabot-preview)
- Dependabot can maintain your repository's dependencies automatically.
- Example: https://github.com/dependabot/dependabot-core/pull/2901

- [Codecov](https://github.com/marketplace/codecov)
- Codecov provides highly integrated tools to group, merge, archive and compare coverage reports.
- Example: https://github.com/codecov/codecov-bash/pull/396

- [Imgbot](https://github.com/marketplace/imgbot)
- Imgbot is a friendly robot that optimizes your images and saves you time. Optimized images mean smaller file sizes without sacrificing quality.
- Example: https://github.com/asdf2014/algorithm/pull/53

- [Pull Request Size](https://github.com/marketplace/pull-request-size)
- Each Pull Request created will be marked with a label in GitHub based on the lines of code changed.
- Example: https://github.com/asdf2014/algorithm/pull/82

- [PEP 8 Speaks](https://github.com/marketplace/pep-8-speaks)
- PEP 8 Speaks is a GitHub app which detects Python code style issues on new Pull Requests.
- Example: https://github.com/asdf2014/algorithm/pull/49

Regards,
Benedict Jin

AW: AW: Propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance

Posted by Christofer Dutz <ch...@c-ware.de>.

Hi Benedict,

no worries, I just wanted to add this thought to the discussion as your initial post sounded a lot like stuff would automatically be updated. So as long as every code change has to signed off by a comitter, I'm fine with that :-)

Chris



-----Ursprüngliche Nachricht-----
Von: Benedict Jin <as...@apache.org> 
Gesendet: Montag, 28. Dezember 2020 10:57
An: dev@iotdb.apache.org
Betreff: Re: AW: Propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance

Hi Christofer Dutz,

Thanks for your comments. I agree with you that we do need to fully understand and test a robot before introducing it. However, as far as I have listed, only some labels will be added and some PRs will be created, but they will not be merged automatically. Therefore, based on past experience, I personally feel that there is no need to worry too much. BTW, let me introduce a scene of the Mergify robot additionally. I see that we need to manually create some backport type PRs. In fact, Mergify can help us create them automatically. Automation not only frees hands, but also ensures the correctness of operation. FYI, https://github.com/apache/iotdb/pull/2357#issuecomment-751651306

Regards,
Benedict Jin

On 2020/12/28 09:19:59, Christofer Dutz <ch...@c-ware.de> wrote: 
> Hi all,
> 
> I would be careful about automating too much. 
> 
> The reason is that changes in the repo have to be an act of the projects committers. By automating merges, dependency-updates and other stuff, we would be technically making github or the apps a committer. We can't do that.
> Especially it would be putting us at risk of getting unwanted stuff in. 
> 
> We can however use the tools to submit PRs with changes and provide  additional information, making things easier for us.
> 
> Also you should probably give Apaches SonarCloud a spin. It has tons of valuable information available in one place.
> 
> Chris
> 
> 
> 
> -----Ursprüngliche Nachricht-----
> Von: Benedict Jin <as...@apache.org> 
> Gesendet: Montag, 28. Dezember 2020 08:44
> An: dev@iotdb.apache.org
> Betreff: Propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance
> 
> Hello everyone,
> 
> As the Apache IoTDB project continues to grow, the maintenance costs that follow have gradually increased. In order to alleviate this problem, I propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance. The following is a list of some robots that I am familiar with, including the official website of the plugin, some brief introductions, and case addresses. I hope it can trigger more great ideas. Welcome to discuss and propose more useful robots.
> 
> - [Mergify](https://github.com/marketplace/mergify)
>   - Mergify is a pull requests automation service. It allows you to trigger actions when your pull requests match defined criteria.
>   - Example: https://github.com/crate/crate/pull/10881
> 
> - [Dependabot](https://github.com/marketplace/dependabot-preview)
>   - Dependabot can maintain your repository's dependencies automatically.
>   - Example: https://github.com/dependabot/dependabot-core/pull/2901
> 
> - [Codecov](https://github.com/marketplace/codecov)
>   - Codecov provides highly integrated tools to group, merge, archive and compare coverage reports.
>   - Example: https://github.com/codecov/codecov-bash/pull/396
> 
> - [Imgbot](https://github.com/marketplace/imgbot)
>   - Imgbot is a friendly robot that optimizes your images and saves you time. Optimized images mean smaller file sizes without sacrificing quality.
>   - Example: https://github.com/asdf2014/algorithm/pull/53
> 
> - [Pull Request Size](https://github.com/marketplace/pull-request-size)
>   - Each Pull Request created will be marked with a label in GitHub based on the lines of code changed.
>   - Example: https://github.com/asdf2014/algorithm/pull/82
> 
> - [PEP 8 Speaks](https://github.com/marketplace/pep-8-speaks)
>   - PEP 8 Speaks is a GitHub app which detects Python code style issues on new Pull Requests.
>   - Example: https://github.com/asdf2014/algorithm/pull/49
> 
> Regards,
> Benedict Jin
>

Re: AW: Propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance

Posted by Benedict Jin <as...@apache.org>.

Hi Christofer Dutz,

Thanks for your comments. I agree with you that we do need to fully understand and test a robot before introducing it. However, as far as I have listed, only some labels will be added and some PRs will be created, but they will not be merged automatically. Therefore, based on past experience, I personally feel that there is no need to worry too much. BTW, let me introduce a scene of the Mergify robot additionally. I see that we need to manually create some backport type PRs. In fact, Mergify can help us create them automatically. Automation not only frees hands, but also ensures the correctness of operation. FYI, https://github.com/apache/iotdb/pull/2357#issuecomment-751651306

Regards,
Benedict Jin

On 2020/12/28 09:19:59, Christofer Dutz <ch...@c-ware.de> wrote: 
> Hi all,
> 
> I would be careful about automating too much. 
> 
> The reason is that changes in the repo have to be an act of the projects committers. By automating merges, dependency-updates and other stuff, we would be technically making github or the apps a committer. We can't do that.
> Especially it would be putting us at risk of getting unwanted stuff in. 
> 
> We can however use the tools to submit PRs with changes and provide  additional information, making things easier for us.
> 
> Also you should probably give Apaches SonarCloud a spin. It has tons of valuable information available in one place.
> 
> Chris
> 
> 
> 
> -----Ursprüngliche Nachricht-----
> Von: Benedict Jin <as...@apache.org> 
> Gesendet: Montag, 28. Dezember 2020 08:44
> An: dev@iotdb.apache.org
> Betreff: Propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance
> 
> Hello everyone,
> 
> As the Apache IoTDB project continues to grow, the maintenance costs that follow have gradually increased. In order to alleviate this problem, I propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance. The following is a list of some robots that I am familiar with, including the official website of the plugin, some brief introductions, and case addresses. I hope it can trigger more great ideas. Welcome to discuss and propose more useful robots.
> 
> - [Mergify](https://github.com/marketplace/mergify)
>   - Mergify is a pull requests automation service. It allows you to trigger actions when your pull requests match defined criteria.
>   - Example: https://github.com/crate/crate/pull/10881
> 
> - [Dependabot](https://github.com/marketplace/dependabot-preview)
>   - Dependabot can maintain your repository's dependencies automatically.
>   - Example: https://github.com/dependabot/dependabot-core/pull/2901
> 
> - [Codecov](https://github.com/marketplace/codecov)
>   - Codecov provides highly integrated tools to group, merge, archive and compare coverage reports.
>   - Example: https://github.com/codecov/codecov-bash/pull/396
> 
> - [Imgbot](https://github.com/marketplace/imgbot)
>   - Imgbot is a friendly robot that optimizes your images and saves you time. Optimized images mean smaller file sizes without sacrificing quality.
>   - Example: https://github.com/asdf2014/algorithm/pull/53
> 
> - [Pull Request Size](https://github.com/marketplace/pull-request-size)
>   - Each Pull Request created will be marked with a label in GitHub based on the lines of code changed.
>   - Example: https://github.com/asdf2014/algorithm/pull/82
> 
> - [PEP 8 Speaks](https://github.com/marketplace/pep-8-speaks)
>   - PEP 8 Speaks is a GitHub app which detects Python code style issues on new Pull Requests.
>   - Example: https://github.com/asdf2014/algorithm/pull/49
> 
> Regards,
> Benedict Jin
>

AW: Propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance

Posted by Christofer Dutz <ch...@c-ware.de>.

Hi all,

I would be careful about automating too much.

The reason is that changes in the repo have to be an act of the projects committers. By automating merges, dependency-updates and other stuff, we would be technically making github or the apps a committer. We can't do that.
Especially it would be putting us at risk of getting unwanted stuff in.

We can however use the tools to submit PRs with changes and provide additional information, making things easier for us.

Also you should probably give Apaches SonarCloud a spin. It has tons of valuable information available in one place.

Chris

-----Ursprüngliche Nachricht-----
Von: Benedict Jin <as...@apache.org>
Gesendet: Montag, 28. Dezember 2020 08:44
An: dev@iotdb.apache.org
Betreff: Propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance

Hello everyone,

Regards,
Benedict Jin

Re: Propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

Also be aware that due to a recent security issue the following now applies applies to GitHub actions:
"Actions in this workflow must be: created by GitHub, verified in the GitHub Marketplace, within a repository owned by
apache or match the following: adoptopenjdk/*, apache/*, gradle/wrapper-validation-action.”

Thanks,
Justin

Re: Propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance

Posted by Xiangdong Huang <sa...@gmail.com>.

Hi,

Thanks for letting us know so many good tools.

I do not believe code changes by robots very much unless I read the code
changes myself.
But I also think having such tools can help us saving time.

- Mergify: I do not like it. :( I think it is dangerous...

- Dependabot: I like this tool. (But we'd better to have a full test, as
some dependencies may lead to performance reduction when it fixes
something.

- Codecov: Well, if someone can set this up, I opt for it! I have spent
more than 3 days to fix the coveralls... but failed. We need code coverage
checking very much.

- Imgbot: OK from my view, as we have few images in the repo.

- Pull Request Size: OK from my view.

- PEP 8 Speaks: I like it.

Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


Benedict Jin <as...@apache.org> 于2020年12月29日周二 下午3:35写道：

> Hi Justin Mclean,
>
> Yep, according to the experience in Apache Druid, we need to create a Jira
> in the Infrastructure project to enable robots. e.g,
> https://issues.apache.org/jira/browse/INFRA-18880
>
> Regards,
> Benedict Jin
>
> On 2020/12/29 06:04:40, Justin Mclean <ju...@classsoftware.com> wrote:
> > HI,
> >
> > How will these bots get access to the repos? Infra tightly controls what
> has access and it be be best to run it past Infra to see if they see any
> issues first with these bots.
> >
> > Thanks,
> > Justin
> >
> >
>

Re: Propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance

Posted by Benedict Jin <as...@apache.org>.

Hi Justin Mclean,

Yep, according to the experience in Apache Druid, we need to create a Jira in the Infrastructure project to enable robots. e.g, https://issues.apache.org/jira/browse/INFRA-18880

Regards,
Benedict Jin

On 2020/12/29 06:04:40, Justin Mclean <ju...@classsoftware.com> wrote: 
> HI,
> 
> How will these bots get access to the repos? Infra tightly controls what has access and it be be best to run it past Infra to see if they see any issues first with these bots.
> 
> Thanks,
> Justin 
> 
>

Re: Propose to use some robots provided in Github's Marketplace to help us improve the efficiency of project maintenance

Posted by Justin Mclean <ju...@classsoftware.com>.

HI,

How will these bots get access to the repos? Infra tightly controls what has access and it be be best to run it past Infra to see if they see any issues first with these bots.

Thanks,
Justin