You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@oozie.apache.org by "Rohini Palaniswamy (JIRA)" <ji...@apache.org> on 2014/07/25 23:36:40 UTC

[jira] [Commented] (OOZIE-1918) ActionXCommand refactoring for code reuse

    [ https://issues.apache.org/jira/browse/OOZIE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074970#comment-14074970 ] 

Rohini Palaniswamy commented on OOZIE-1918:
-------------------------------------------

I always like having lesser lines of code :). Thanks for doing some cleanup. 

> ActionXCommand refactoring for code reuse
> -----------------------------------------
>
>                 Key: OOZIE-1918
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1918
>             Project: Oozie
>          Issue Type: Improvement
>          Components: action
>    Affects Versions: trunk
>            Reporter: Azrael
>            Assignee: Azrael
>            Priority: Trivial
>         Attachments: OOZIE-1918.1.patch, OOZIE-1918.2.patch
>
>
> Subclasses of ActionXCommand have some duplicated code. Refactoring make it more neat.
> This patch contain:
> * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending ActionXCommand
> * Moving some variables and methods to ActionXCommand and making it protected
> * More meaningful log message : actionId is duplicated so removed



--
This message was sent by Atlassian JIRA
(v6.2#6252)