You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2016/02/25 16:13:10 UTC
[GitHub] flink pull request: [FLINK-3496] Fix ML test discovery on Windows
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1710
[FLINK-3496] Fix ML test discovery on Windows
This PR adds OS specific arguments in the flink-ml pom that are passed to the scala test runner.
The runner uses pattern matching to discover test files that should be run. The original pattern without quotes works on unix but fails on windows, with quotes it works on windows but skip all tests on unix.
As such I've added 2 profiles that activate based on the OS and set a pattern property, which is then passed to the runner.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 3496_ml_pattern
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1710.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1710
----
commit efc62c42879508450544ca72d464420bf3934724
Author: zentol <s....@web.de>
Date: 2016-02-25T15:09:42Z
[FLINK-3496] Fix ML test discovery on Windows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3496] Fix ML test discovery on Windows
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1710#issuecomment-189259306
Looks good, test failure is unrelated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3496] Fix ML test discovery on Windows
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1710
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3496] Fix ML test discovery on Windows
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1710#issuecomment-191796890
Will merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---